jenkins-bot has submitted this change and it was merged. Change subject: [BrowserTest] Revert the definition of the disabled_save_button element ......................................................................
[BrowserTest] Revert the definition of the disabled_save_button element The element is <div>, and using English text doesn't work in other languages. Follow up to Icd79ec9b489557c3259ff7f2c11b2a899c767d0f Change-Id: I3859c668921a5f3f6abafb2053fc471dbc8d80c7 --- M modules/ve-mw/tests/browser/features/support/pages/visual_editor_page.rb 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Zfilipin: Looks good to me, approved jenkins-bot: Verified diff --git a/modules/ve-mw/tests/browser/features/support/pages/visual_editor_page.rb b/modules/ve-mw/tests/browser/features/support/pages/visual_editor_page.rb index 1e4d6f6..b81aa5e 100644 --- a/modules/ve-mw/tests/browser/features/support/pages/visual_editor_page.rb +++ b/modules/ve-mw/tests/browser/features/support/pages/visual_editor_page.rb @@ -46,7 +46,7 @@ span(:decrease_indentation, class: 'oo-ui-iconElement-icon oo-ui-icon-outdent-list') text_area(:describe_change, index: 0) table(:diff_view, css: '.ve-ui-mwSaveDialog-viewer table.diff') - a(:disabled_save_button, class: 'oo-ui-widget oo-ui-widget-disabled oo-ui-buttonElement oo-ui-buttonElement-framed oo-ui-labelElement oo-ui-flaggedElement-progressive oo-ui-flaggedElement-primary oo-ui-buttonWidget ve-ui-toolbar-saveButton oo-ui-image-invert', text: 'Save page') + div(:disabled_save_button, css: 'div.ve-init-mw-viewPageTarget-toolbar-actions > div.oo-ui-flaggedElement-progressive.oo-ui-widget-disabled') text_field(:display_title_textbox, css: 'div.oo-ui-fieldLayout-align-inline:nth-child(4) > label:nth-child(1) > div:nth-child(1) > div:nth-child(1) > input:nth-child(1)') div(:enable_redirect, class: 've-test-page-settings-enable-redirect') div(:prevent_redirect, class: 've-test-page-settings-prevent-redirect') -- To view, visit https://gerrit.wikimedia.org/r/197886 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3859c668921a5f3f6abafb2053fc471dbc8d80c7 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/VisualEditor Gerrit-Branch: master Gerrit-Owner: Amire80 <[email protected]> Gerrit-Reviewer: Zfilipin <[email protected]> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
