jenkins-bot has submitted this change and it was merged.
Change subject: [BrowserTest] Remove when_not_visible check from 'I click Save
page'
......................................................................
[BrowserTest] Remove when_not_visible check from 'I click Save page'
The when_not_visible line fails, but it doesn't seem to be needed
in the first place. The when_present line appears to be enough.
Change-Id: I572dabb5d53553d454f6e40c5602fbe3252c3657
---
M modules/ve-mw/tests/browser/features/step_definitions/shared_steps.rb
1 file changed, 0 insertions(+), 1 deletion(-)
Approvals:
Zfilipin: Looks good to me, approved
jenkins-bot: Verified
diff --git
a/modules/ve-mw/tests/browser/features/step_definitions/shared_steps.rb
b/modules/ve-mw/tests/browser/features/step_definitions/shared_steps.rb
index c23de78..bf38408 100644
--- a/modules/ve-mw/tests/browser/features/step_definitions/shared_steps.rb
+++ b/modules/ve-mw/tests/browser/features/step_definitions/shared_steps.rb
@@ -48,7 +48,6 @@
When(/^I click Save page$/) do
on(VisualEditorPage) do |page|
- page.disabled_save_button_element.when_not_visible(15)
page.save_page_element.when_present.click
end
end
--
To view, visit https://gerrit.wikimedia.org/r/197894
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I572dabb5d53553d454f6e40c5602fbe3252c3657
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Amire80 <[email protected]>
Gerrit-Reviewer: Zfilipin <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
