Esanders has uploaded a new change for review.
https://gerrit.wikimedia.org/r/197906
Change subject: Fix context height and padding
......................................................................
Fix context height and padding
* Remove 1.5em line height from overlay, causes problems with
button heights.
* Make context body bottom padding 1em, looks better.
* Add 0.2em height (same as shadow) when body is empty to avoid
unbalanced margins around framed action button.
Change-Id: I81c28bdef85447454b3e4f5b6b5286f7e315725b
---
M src/themes/mediawiki/widgets.css
M src/ui/styles/ve.ui.ContextItem.css
M src/ui/styles/ve.ui.Overlay.css
3 files changed, 11 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor
refs/changes/06/197906/1
diff --git a/src/themes/mediawiki/widgets.css b/src/themes/mediawiki/widgets.css
index c5cdba6..0696ad5 100644
--- a/src/themes/mediawiki/widgets.css
+++ b/src/themes/mediawiki/widgets.css
@@ -9,3 +9,9 @@
.ve-ui-surfaceWidget {
border: 1px solid #ccc;
}
+
+/* Context item */
+
+.ve-ui-contextItem-body {
+ min-height: 0.2em;
+}
diff --git a/src/ui/styles/ve.ui.ContextItem.css
b/src/ui/styles/ve.ui.ContextItem.css
index 3fee4b7..318bb0c 100644
--- a/src/ui/styles/ve.ui.ContextItem.css
+++ b/src/ui/styles/ve.ui.ContextItem.css
@@ -76,11 +76,14 @@
}
.ve-ui-contextItem-body {
- padding: 0 1em 0.5em 1em;
max-height: 15em;
overflow: auto;
}
+.ve-ui-contextItem-body:not(:empty) {
+ padding: 0 1em 1em 1em;
+}
+
.ve-ui-contextItem + .ve-ui-contextItem {
border-top: 1px solid #eee;
}
diff --git a/src/ui/styles/ve.ui.Overlay.css b/src/ui/styles/ve.ui.Overlay.css
index f80152c..bf55e67 100644
--- a/src/ui/styles/ve.ui.Overlay.css
+++ b/src/ui/styles/ve.ui.Overlay.css
@@ -6,7 +6,7 @@
.ve-ui-overlay {
font-family: sans-serif;
- line-height: 1.5em;
+ line-height: 1em;
font-size: 1em;
position: absolute;
top: 0;
--
To view, visit https://gerrit.wikimedia.org/r/197906
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I81c28bdef85447454b3e4f5b6b5286f7e315725b
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
