jenkins-bot has submitted this change and it was merged.
Change subject: Refactor expandLinearSelection test into a case loop
......................................................................
Refactor expandLinearSelection test into a case loop
Change-Id: I694d54f5470a2b70abe4fce065686e426f515993
---
M tests/dm/ve.dm.SurfaceFragment.test.js
1 file changed, 16 insertions(+), 9 deletions(-)
Approvals:
Catrope: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/dm/ve.dm.SurfaceFragment.test.js
b/tests/dm/ve.dm.SurfaceFragment.test.js
index e02af3f..e233337 100644
--- a/tests/dm/ve.dm.SurfaceFragment.test.js
+++ b/tests/dm/ve.dm.SurfaceFragment.test.js
@@ -95,17 +95,24 @@
assert.equalRange( collapsedFragment.getSelection().getRange(), new
ve.Range( 21 ), 'range is at end when collapseToEnd is set' );
} );
-QUnit.test( 'expandLinearSelection (closest)', 1, function ( assert ) {
- var doc = ve.dm.example.createExampleDocument(),
+QUnit.test( 'expandLinearSelection (closest)', function ( assert ) {
+ var i, fragment,
+ doc = ve.dm.example.createExampleDocument(),
surface = new ve.dm.Surface( doc ),
- fragment = surface.getLinearFragment( new ve.Range( 20, 21 ) ),
- expandedFragment = fragment.expandLinearSelection( 'closest',
function () {} );
+ cases = [
+ {
+ msg: 'closest with invalid type results in null
fragment',
+ range: new ve.Range( 20, 21 ),
+ type: function () {},
+ expected: new ve.dm.NullSelection( doc )
+ }
+ ];
- assert.equalHash(
- expandedFragment.getSelection(),
- new ve.dm.NullSelection( doc ),
- 'closest with invalid type results in null fragment'
- );
+ QUnit.expect( cases.length );
+ for ( i = 0; i < cases.length; i++ ) {
+ fragment = surface.getLinearFragment( cases[i].range
).expandLinearSelection( 'closest', cases[i].type );
+ assert.equalHash( fragment.getSelection(), cases[i].expected,
cases[i].msg );
+ }
} );
QUnit.test( 'expandLinearSelection (word)', 1, function ( assert ) {
--
To view, visit https://gerrit.wikimedia.org/r/197953
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I694d54f5470a2b70abe4fce065686e426f515993
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
Gerrit-Reviewer: Catrope <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
