Legoktm has uploaded a new change for review.
https://gerrit.wikimedia.org/r/197964
Change subject: Use UserGetReservedNames hook instead of modifying a global at
run-time
......................................................................
Use UserGetReservedNames hook instead of modifying a global at run-time
Change-Id: I2ad98f8122f7a0b77b8f42612597fe350e5d3075
---
M Translate.php
M TranslateHooks.php
2 files changed, 8 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Translate
refs/changes/64/197964/1
diff --git a/Translate.php b/Translate.php
index 76daa79..eae4258 100644
--- a/Translate.php
+++ b/Translate.php
@@ -136,6 +136,7 @@
'TranslateHooks::translateMessageDocumentationLanguage';
$GLOBALS['wgHooks']['ArticlePrepareTextForEdit'][] =
'TranslateEditAddons::disablePreSaveTransform';
$GLOBALS['wgHooks']['ParserFirstCallInit'][] =
'TranslateHooks::setupTranslateParserFunction';
+$GLOBALS['wgHooks']['UserGetReservedNames'][] =
'TranslateHooks::onUserGetReservedNames';
// Prevent translations creating bogus categories
$GLOBALS['wgHooks']['LinksUpdate'][] = 'TranslateHooks::preventCategorization';
diff --git a/TranslateHooks.php b/TranslateHooks.php
index a49d1a4..38a7747 100644
--- a/TranslateHooks.php
+++ b/TranslateHooks.php
@@ -42,9 +42,6 @@
$wgAutoloadClasses['PHPlot'] = $wgTranslatePHPlot;
}
- global $wgReservedUsernames, $wgTranslateFuzzyBotName;
- $wgReservedUsernames[] = $wgTranslateFuzzyBotName;
-
// Page translation setup check and init if enabled.
global $wgEnablePageTranslation;
if ( $wgEnablePageTranslation ) {
@@ -170,6 +167,13 @@
}
}
+ public static function onUserGetReservedNames( &$names ) {
+ global $wgTranslateFuzzyBotName;
+ $names[] = $wgTranslateFuzzyBotName;
+
+ return true;
+ }
+
/**
* Hook: ParserFirstCallInit
* Registers \<languages> tag with the parser.
--
To view, visit https://gerrit.wikimedia.org/r/197964
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2ad98f8122f7a0b77b8f42612597fe350e5d3075
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Legoktm <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
