jenkins-bot has submitted this change and it was merged.
Change subject: Revert "Correct the arrow position of the editor tutorial"
......................................................................
Revert "Correct the arrow position of the editor tutorial"
This reverts commit 51065d7d599645699ca11e38479c237062b1ec0b.
Change-Id: I3bda4c19e4a461e5d276da55399232c71515ad86
---
M javascripts/modules/tutorials/ContentOverlay.js
1 file changed, 9 insertions(+), 18 deletions(-)
Approvals:
Jdlrobson: Looks good to me, approved
jenkins-bot: Verified
Objections:
Bmansurov: There's a problem with this change, please improve
diff --git a/javascripts/modules/tutorials/ContentOverlay.js
b/javascripts/modules/tutorials/ContentOverlay.js
index f044808..8f36fb1 100644
--- a/javascripts/modules/tutorials/ContentOverlay.js
+++ b/javascripts/modules/tutorials/ContentOverlay.js
@@ -26,29 +26,20 @@
appendToElement: '#mw-mf-page-center',
/** @inheritdoc */
postRender: function ( options ) {
- var self = this,
- $target,
- targetOffset,
- intervalID;
+ var $target,
+ self = this;
Overlay.prototype.postRender.apply( this, arguments );
if ( options.target ) {
$target = $( options.target );
- targetOffset = $target.offset();
+ // Ensure we position the overlay correctly but
do not show the arrow
self._position( $target );
- self.addPointerArrow( $target );
- // Listen to changes of the position of
'target' and reposition the overlay accordingly
- intervalID = setInterval( function () {
- var newOffset = $target.offset();
- if ( targetOffset.left !==
newOffset.left || targetOffset.top !== newOffset.top ) {
- self._position( $target );
- self.refreshPointerArrow(
options.target );
- }
- }, 1000 );
- // stop listening
- self.on( 'hide', function () {
- clearInterval( intervalID );
- } );
+ // Ensure that any reflows due to tablet styles
have happened before showing
+ // the arrow.
+ setTimeout( function () {
+ self.addPointerArrow( $target );
+ M.on( 'resize', $.proxy( self,
'refreshPointerArrow', options.target ) );
+ }, 0 );
}
},
/**
--
To view, visit https://gerrit.wikimedia.org/r/197970
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3bda4c19e4a461e5d276da55399232c71515ad86
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Robmoen <[email protected]>
Gerrit-Reviewer: Bmansurov <[email protected]>
Gerrit-Reviewer: Jdlrobson <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
