Trevor Parscal has uploaded a new change for review.
https://gerrit.wikimedia.org/r/198129
Change subject: Initialize label of TransclusionDialog mode button
......................................................................
Initialize label of TransclusionDialog mode button
Because the mode label is set after measurements of the foot are made, the body
of a ProcessDialog was set to overlap the foot.
At some point T93290 will be fixed, but in the mean time we can solve this
problem by setting an initially.
Bug: T92986
Change-Id: I995d5ecd81b86ee188cf237f74487ec70480e297
---
M modules/ve-mw/ui/dialogs/ve.ui.MWTransclusionDialog.js
1 file changed, 4 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/29/198129/1
diff --git a/modules/ve-mw/ui/dialogs/ve.ui.MWTransclusionDialog.js
b/modules/ve-mw/ui/dialogs/ve.ui.MWTransclusionDialog.js
index 303db80..3ec2650 100644
--- a/modules/ve-mw/ui/dialogs/ve.ui.MWTransclusionDialog.js
+++ b/modules/ve-mw/ui/dialogs/ve.ui.MWTransclusionDialog.js
@@ -36,7 +36,10 @@
ve.ui.MWTransclusionDialog.static.actions =
ve.ui.MWTemplateDialog.static.actions.concat( [
{
action: 'mode',
- modes: [ 'edit', 'insert' ]
+ modes: [ 'edit', 'insert' ],
+ // HACK: Will be set later, but we want measurements to be
accurate in the mean time, this
+ // will not be needed when T93290 is resolved
+ label: $( document.createTextNode( ' ' ) )
}
] );
--
To view, visit https://gerrit.wikimedia.org/r/198129
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I995d5ecd81b86ee188cf237f74487ec70480e297
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Trevor Parscal <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
