jenkins-bot has submitted this change and it was merged.
Change subject: build: Add assert-mw-env task when running grunt-qunit
......................................................................
build: Add assert-mw-env task when running grunt-qunit
Previously it gave cryptic error messages like:
> Running "karma" task
> > Warning: Parameter 'url' must be a string, not number
Change-Id: I0adb0f2f501dd5db2d6738a40efbce349f0175d2
---
M Gruntfile.js
1 file changed, 14 insertions(+), 1 deletion(-)
Approvals:
Jforrester: Looks good to me, approved
jenkins-bot: Verified
diff --git a/Gruntfile.js b/Gruntfile.js
index a292d0b..5d6dc17 100644
--- a/Gruntfile.js
+++ b/Gruntfile.js
@@ -97,8 +97,21 @@
}
} );
+ grunt.registerTask( 'assert-mw-env', function () {
+ if ( !process.env.MW_SERVER ) {
+ grunt.log.error( 'Environment variable MW_SERVER must
be set.\n' +
+ 'Set this like $wgServer, e.g.
"http://localhost";'
+ );
+ }
+ if ( !process.env.MW_SCRIPT_PATH ) {
+ grunt.log.error( 'Environment variable MW_SCRIPT_PATH
must be set.\n' +
+ 'Set this like $wgScriptPath, e.g. "/w"');
+ }
+ return !!( process.env.MW_SERVER && process.env.MW_SCRIPT_PATH
);
+ } );
+
grunt.registerTask( 'lint', ['jshint', 'jscs', 'jsonlint', 'banana'] );
- grunt.registerTask( 'qunit', 'karma:main' );
+ grunt.registerTask( 'qunit', [ 'assert-mw-env', 'karma:main' ] );
grunt.registerTask( 'test', ['lint'] );
grunt.registerTask( 'default', 'test' );
--
To view, visit https://gerrit.wikimedia.org/r/198177
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0adb0f2f501dd5db2d6738a40efbce349f0175d2
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Krinkle <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
