jenkins-bot has submitted this change and it was merged.
Change subject: Make text in certain TextViews selectable (for copying)
......................................................................
Make text in certain TextViews selectable (for copying)
This allows the user to long-press text fields such as the page title or
description, gallery info text, etc. for copying the text to the clipboard
of the device.
Change-Id: Idbafb9e3fa06006c9922917ae798766ed0bc1120
---
M wikipedia/res/layout/activity_about.xml
M wikipedia/res/layout/activity_gallery.xml
M wikipedia/res/layout/fragment_page.xml
M wikipedia/res/layout/group_bottom_content.xml
4 files changed, 13 insertions(+), 0 deletions(-)
Approvals:
BearND: Looks good to me, approved
jenkins-bot: Verified
diff --git a/wikipedia/res/layout/activity_about.xml
b/wikipedia/res/layout/activity_about.xml
index e5296f0..755bf32 100644
--- a/wikipedia/res/layout/activity_about.xml
+++ b/wikipedia/res/layout/activity_about.xml
@@ -48,6 +48,7 @@
android:layout_height="24dp"
tools:text="2.x-sample-version"
style="?android:textAppearanceMedium"
+ android:textIsSelectable="true"
android:gravity="bottom"
/>
</LinearLayout>
@@ -67,6 +68,7 @@
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:text="@string/contributors_list"
style="?android:textAppearanceSmall"
+ android:textIsSelectable="true"
android:lineSpacingMultiplier="1.2"
android:textColor="#555"
android:layout_marginBottom="8dp"
@@ -87,6 +89,7 @@
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:text="@string/about_translators_translatewiki"
style="?android:textAppearanceSmall"
+ android:textIsSelectable="true"
android:lineSpacingMultiplier="1.2"
android:textColor="#555"
android:textColorLink="?attr/link_color"
@@ -107,6 +110,7 @@
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:text="@string/libraries_list"
style="?android:textAppearanceSmall"
+ android:textIsSelectable="true"
android:lineSpacingMultiplier="1.2"
android:textColor="#555"
android:textColorLink="?attr/link_color"
@@ -137,6 +141,7 @@
android:layout_width="0dp"
android:layout_height="match_parent"
android:gravity="center_vertical"
android:text="@string/about_wmf"
style="?android:textAppearanceSmall"
+ android:textIsSelectable="true"
android:layout_weight="1"
android:textColor="#555"
android:textColorLink="?attr/link_color"
diff --git a/wikipedia/res/layout/activity_gallery.xml
b/wikipedia/res/layout/activity_gallery.xml
index b7d584b..6dded13 100644
--- a/wikipedia/res/layout/activity_gallery.xml
+++ b/wikipedia/res/layout/activity_gallery.xml
@@ -47,6 +47,7 @@
android:paddingLeft="@dimen/activity_horizontal_margin"
android:paddingRight="@dimen/activity_horizontal_margin"
android:maxHeight="128dp"
+ android:textIsSelectable="true"
android:scrollbarStyle="insideInset"
android:scrollbars="vertical"
android:fadeScrollbars="false"
@@ -75,6 +76,7 @@
android:layout_height="wrap_content"
android:paddingLeft="2dp"
android:paddingRight="2dp"
+ android:textIsSelectable="true"
tools:text="Credits"
android:textColor="@color/gallery_license_text"
android:textColorLink="@color/gallery_license_text"
diff --git a/wikipedia/res/layout/fragment_page.xml
b/wikipedia/res/layout/fragment_page.xml
index 21902bc..e25a911 100644
--- a/wikipedia/res/layout/fragment_page.xml
+++ b/wikipedia/res/layout/fragment_page.xml
@@ -66,6 +66,7 @@
android:id="@+id/page_title_text"
android:layout_width="match_parent"
android:layout_height="wrap_content"
+ android:textIsSelectable="true"
android:fontFamily="serif"
android:paddingTop="16dp"
android:paddingBottom="16dp"
@@ -77,6 +78,7 @@
android:layout_height="wrap_content"
android:layout_gravity="bottom"
android:visibility="invisible"
+ android:textIsSelectable="true"
android:fontFamily="serif"
android:textSize="@dimen/descriptionTextSize"
android:paddingBottom="16dp"
@@ -140,6 +142,7 @@
android:paddingLeft="@dimen/activity_horizontal_margin"
android:paddingRight="@dimen/activity_horizontal_margin"
style="?android:textAppearanceSmall"
+ android:textIsSelectable="true"
android:textColorLink="?attr/link_color"/>
<TextView
android:id="@+id/page_license_text"
@@ -148,6 +151,7 @@
android:paddingLeft="@dimen/activity_horizontal_margin"
android:paddingRight="@dimen/activity_horizontal_margin"
style="?android:textAppearanceSmall"
+ android:textIsSelectable="true"
android:textColorLink="?attr/link_color"
android:gravity="center"/>
</LinearLayout>
diff --git a/wikipedia/res/layout/group_bottom_content.xml
b/wikipedia/res/layout/group_bottom_content.xml
index fdaa1ed..e0f1970 100644
--- a/wikipedia/res/layout/group_bottom_content.xml
+++ b/wikipedia/res/layout/group_bottom_content.xml
@@ -50,6 +50,7 @@
android:id="@+id/read_next_title_text"
android:layout_width="match_parent"
android:layout_height="wrap_content"
+ android:textIsSelectable="true"
android:fontFamily="serif"
android:textSize="@dimen/titleTextSize"
android:textColor="@color/lead_text_color"
@@ -66,6 +67,7 @@
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:layout_gravity="bottom"
+ android:textIsSelectable="true"
android:fontFamily="serif"
android:textSize="@dimen/descriptionTextSize"
android:textColor="@color/lead_text_color"
--
To view, visit https://gerrit.wikimedia.org/r/197912
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idbafb9e3fa06006c9922917ae798766ed0bc1120
Gerrit-PatchSet: 2
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Dbrant <dbr...@wikimedia.org>
Gerrit-Reviewer: BearND <bsitzm...@wikimedia.org>
Gerrit-Reviewer: Brion VIBBER <br...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
