jenkins-bot has submitted this change and it was merged. Change subject: Apply a Ken Burns effect to the lead image. ......................................................................
Apply a Ken Burns effect to the lead image. (only for non-production for now) Change-Id: Ic4f9eadc173a16e5e1b25175874e783b13d60631 --- A wikipedia/res/anim/lead_image_zoom.xml M wikipedia/src/main/java/org/wikipedia/page/leadimages/LeadImagesHandler.java 2 files changed, 18 insertions(+), 0 deletions(-) Approvals: BearND: Looks good to me, approved jenkins-bot: Verified diff --git a/wikipedia/res/anim/lead_image_zoom.xml b/wikipedia/res/anim/lead_image_zoom.xml new file mode 100644 index 0000000..a94ed91 --- /dev/null +++ b/wikipedia/res/anim/lead_image_zoom.xml @@ -0,0 +1,9 @@ +<?xml version="1.0" encoding="utf-8"?> +<scale xmlns:android="http://schemas.android.com/apk/res/android"; + android:duration="2000" + android:fromXScale="1" + android:fromYScale="1" + android:pivotX="50%" + android:pivotY="50%" + android:toXScale="1.07" + android:toYScale="1.07" /> \ No newline at end of file diff --git a/wikipedia/src/main/java/org/wikipedia/page/leadimages/LeadImagesHandler.java b/wikipedia/src/main/java/org/wikipedia/page/leadimages/LeadImagesHandler.java index 8c69402..b017205 100644 --- a/wikipedia/src/main/java/org/wikipedia/page/leadimages/LeadImagesHandler.java +++ b/wikipedia/src/main/java/org/wikipedia/page/leadimages/LeadImagesHandler.java @@ -13,6 +13,7 @@ import android.view.View; import android.view.ViewGroup; import android.view.animation.Animation; +import android.view.animation.AnimationUtils; import android.view.animation.Transformation; import android.webkit.WebView; import android.widget.FrameLayout; @@ -287,6 +288,14 @@ // fade in the new image! ViewAnimations.crossFade(imagePlaceholder, image1); + + if (WikipediaApp.getInstance().getReleaseType() != WikipediaApp.RELEASE_PROD) { + // and perform a subtle Ken Burns animation... + Animation anim = AnimationUtils.loadAnimation(parentFragment.getActivity(), + R.anim.lead_image_zoom); + anim.setFillAfter(true); + image1.startAnimation(anim); + } } }); } -- To view, visit https://gerrit.wikimedia.org/r/198082 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic4f9eadc173a16e5e1b25175874e783b13d60631 Gerrit-PatchSet: 3 Gerrit-Project: apps/android/wikipedia Gerrit-Branch: master Gerrit-Owner: Dbrant <dbr...@wikimedia.org> Gerrit-Reviewer: BearND <bsitzm...@wikimedia.org> Gerrit-Reviewer: Brion VIBBER <br...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
