jenkins-bot has submitted this change and it was merged.
Change subject: Avoid flash of unstyled content
......................................................................
Avoid flash of unstyled content
Move lists.less into ext.gather.styles module since the file is in
the ext.gather.styles folder and this is confusing.
Drop use of addModules which causes styles to be loaded via JavaScript
Change-Id: I04040e8543372772501da31ea6e2c57d33975364
---
M includes/specials/SpecialGatherLists.php
M resources/Resources.php
2 files changed, 1 insertion(+), 3 deletions(-)
Approvals:
Robmoen: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/specials/SpecialGatherLists.php
b/includes/specials/SpecialGatherLists.php
index d29bd7b..cc5c302 100644
--- a/includes/specials/SpecialGatherLists.php
+++ b/includes/specials/SpecialGatherLists.php
@@ -19,9 +19,6 @@
public function __construct() {
parent::__construct( 'GatherLists' );
$out = $this->getOutput();
- $out->addModules( array(
- 'ext.gather.lists'
- ) );
$out->addModuleStyles( array(
'mediawiki.ui.anchor',
'mediawiki.ui.icon',
diff --git a/resources/Resources.php b/resources/Resources.php
index 97d439a..031b500 100644
--- a/resources/Resources.php
+++ b/resources/Resources.php
@@ -64,6 +64,7 @@
'ext.gather.styles' => $wgGatherMobileSpecialPageResourceBoilerplate +
array(
'styles' => array(
'ext.gather.styles/collections.less',
+ 'ext.gather.styles/lists.less',
),
),
--
To view, visit https://gerrit.wikimedia.org/r/198372
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I04040e8543372772501da31ea6e2c57d33975364
Gerrit-PatchSet: 5
Gerrit-Project: mediawiki/extensions/Gather
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <jrob...@wikimedia.org>
Gerrit-Reviewer: Robmoen <rm...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
