Kaldari has uploaded a new change for review.
https://gerrit.wikimedia.org/r/198439
Change subject: Fix WikiGrok since M.util.query has been removed
......................................................................
Fix WikiGrok since M.util.query has been removed
Change Iab3963ff32e961e removed M.util.query from MobileFrontend.
This broke WikiGrok. Migrating to mw.util.getParamValue() instead.
Change-Id: Iec801d9b287fad43ec3ab2649a2212e6f687aa0e
---
M resources/startup/init.js
1 file changed, 5 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikiGrok
refs/changes/39/198439/1
diff --git a/resources/startup/init.js b/resources/startup/init.js
index 03fd5de..eae2d03 100644
--- a/resources/startup/init.js
+++ b/resources/startup/init.js
@@ -1,12 +1,10 @@
// Determine whether or not it is appropriate to load WikiGrok, and if so,
load it.
( function ( M, $ ) {
var wikidataID = M.require( 'util' ).getWikiBaseItemId(),
- util = M.require( 'util' ),
overlayManager = M.require( 'overlayManager' ),
Schema = M.require( 'Schema' ),
errorSchema = new Schema( {}, 'MobileWebWikiGrokError' ),
settings = M.require( 'settings' ),
- query = util.query,
browser = M.require( 'browser' ),
permittedOnThisDevice = mw.config.get(
'wgWikiGrokUIEnableOnAllDevices' ) || !browser.isWideScreen(),
idOverride,
@@ -62,7 +60,7 @@
* @return {Object|null}
*/
function getWikiGrokConfig() {
- var wikiGrokVersion = query.wikigrokversion || DEFAULT_VERSION;
+ var wikiGrokVersion = mw.util.getParamValue( 'wikigrokversion'
) || DEFAULT_VERSION;
if ( window.location.hash.toLowerCase() ===
'#wikigrokversion=c' ) {
wikiGrokVersion = 'c';
@@ -102,7 +100,10 @@
wikidataID
) {
// Bypass certain conditions when debugging or using
WikiGrok Roulette
- if ( query.wikidataid || query.wikigrokversion ||
versionConfigs.name === 'c' ) {
+ if ( mw.util.getParamValue( 'wikidataid' ) ||
+ mw.util.getParamValue( 'wikigrokversion' ) ||
+ versionConfigs.name === 'c'
+ ) {
return true;
}
if (
--
To view, visit https://gerrit.wikimedia.org/r/198439
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iec801d9b287fad43ec3ab2649a2212e6f687aa0e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikiGrok
Gerrit-Branch: master
Gerrit-Owner: Kaldari <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
