jenkins-bot has submitted this change and it was merged.
Change subject: Remove a hack, and a hack for the hack, for MediaWiki UI input
fields
......................................................................
Remove a hack, and a hack for the hack, for MediaWiki UI input fields
Hack #1: We were ignoring the 'size' attribute of input fields when
$wgUseMediaWikiUIEverywhere was true. Let's not do that.
Hack #2: We were setting a min-width for MediaWiki UI input fields,
because fields which were supposed to be full-line were becoming
tiny because of hack #1. Let's not do that either.
Bug: T92498
Change-Id: I1d2c6c9eb60b52a7267c122a719cfdaa1f74f815
---
M includes/Html.php
M resources/src/mediawiki.ui/components/inputs.less
2 files changed, 0 insertions(+), 12 deletions(-)
Approvals:
Jdlrobson: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/Html.php b/includes/Html.php
index 8799225..ed77729 100644
--- a/includes/Html.php
+++ b/includes/Html.php
@@ -151,10 +151,6 @@
} else {
$attrs['class'] = 'mw-ui-input';
}
-
- // Note that size can effect the desired width
rendering of mw-ui-input elements
- // so it is removed. Left intact when mediawiki ui not
enabled.
- unset( $attrs['size'] );
}
return $attrs;
}
diff --git a/resources/src/mediawiki.ui/components/inputs.less
b/resources/src/mediawiki.ui/components/inputs.less
index 1992cce..2f76131 100644
--- a/resources/src/mediawiki.ui/components/inputs.less
+++ b/resources/src/mediawiki.ui/components/inputs.less
@@ -128,11 +128,3 @@
font-weight: bold;
line-height: 1.25em;
}
-
-// Tablet and desktop specific styling tweaks.
-@media all and (min-width: 768px) {
- // Make inline elements take up a sensible amount of the screen on
wider devices.
- .mw-ui-input-inline {
- min-width: 320px;
- }
-}
--
To view, visit https://gerrit.wikimedia.org/r/196627
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1d2c6c9eb60b52a7267c122a719cfdaa1f74f815
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: Daniel Friesen <[email protected]>
Gerrit-Reviewer: Jack Phoenix <[email protected]>
Gerrit-Reviewer: Jdlrobson <[email protected]>
Gerrit-Reviewer: Kaldari <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
