jenkins-bot has submitted this change and it was merged.
Change subject: Make status output prettier for log files
......................................................................
Make status output prettier for log files
use newlines rather than carriage returns when stdout is not a tty (e.g.
when scap or sync-* is run from a cron job or piped to a log file).
Change-Id: I10bbde194e62d8631a135c2594390ea9496aa9e9
---
M scap/log.py
1 file changed, 5 insertions(+), 1 deletion(-)
Approvals:
Krinkle: Looks good to me, but someone else must approve
20after4: Looks good to me, approved
jenkins-bot: Verified
diff --git a/scap/log.py b/scap/log.py
index 735d096..012f77a 100644
--- a/scap/log.py
+++ b/scap/log.py
@@ -225,7 +225,11 @@
self._progress()
def _progress(self):
- self._fd.write('%-80s\r' % self._output())
+ if sys.stdout.isatty():
+ fmt = '%-80s\r'
+ else:
+ fmt = '%-80s\n'
+ self._fd.write(fmt % self._output())
def _output(self):
return '%s: %3.0f%% (ok: %d; fail: %d; left: %d)' % (
--
To view, visit https://gerrit.wikimedia.org/r/198449
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I10bbde194e62d8631a135c2594390ea9496aa9e9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/tools/scap
Gerrit-Branch: master
Gerrit-Owner: BryanDavis <[email protected]>
Gerrit-Reviewer: 20after4 <[email protected]>
Gerrit-Reviewer: BryanDavis <[email protected]>
Gerrit-Reviewer: Chad <[email protected]>
Gerrit-Reviewer: Krinkle <[email protected]>
Gerrit-Reviewer: Thcipriani <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
