Daniel Kinzler has submitted this change and it was merged. Change subject: (bug 32368) Add ParserCloned hook ......................................................................
(bug 32368) Add ParserCloned hook We store various bits of data as "expando" properties on the Parser object, to pass information from one stage of the parser to another. If the parser is cloned, however, we can run into trouble because two different Parser objects are now manipulating the same extension data structure; this often shows up when ParserClearState is called on one clone and clears the state of the other as well. Since a deep clone might be too expensive and still might be wrong in some cases, it seems most useful to simply provide a ParserCloned hook so extensions can just do The Right Thing. Change-Id: Ieec65c908d71e89b9a66f83b9a626f842aadacbb --- M docs/hooks.txt M includes/parser/Parser.php 2 files changed, 10 insertions(+), 0 deletions(-) Approvals: Daniel Kinzler: Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/33506 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieec65c908d71e89b9a66f83b9a626f842aadacbb Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Anomie <[email protected]> Gerrit-Reviewer: Anomie <[email protected]> Gerrit-Reviewer: Daniel Kinzler <[email protected]> Gerrit-Reviewer: IAlex <[email protected]> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
