jenkins-bot has submitted this change and it was merged.
Change subject: I can has proper PHP?
......................................................................
I can has proper PHP?
Change-Id: I942d41612f002558d9216c25f7855e93f7c73131
---
M WikiArticleFeeds_body.php
1 file changed, 4 insertions(+), 2 deletions(-)
Approvals:
Legoktm: Looks good to me, approved
jenkins-bot: Verified
diff --git a/WikiArticleFeeds_body.php b/WikiArticleFeeds_body.php
index c2e47c6..c3e29bc 100644
--- a/WikiArticleFeeds_body.php
+++ b/WikiArticleFeeds_body.php
@@ -328,11 +328,13 @@
# Determine Feed item depth (what header level defines
a feed)
preg_match_all( '/<h(\\d)>/m', $feedContent, $matches );
if ( !isset( $matches[1] ) ) {
- next;
+ continue;
}
$lvl = $matches[1][0];
foreach ( $matches[1] as $match ) {
- if ( $match < $lvl ) $lvl = $match;
+ if ( $match < $lvl ) {
+ $lvl = $match;
+ }
}
$sectionRegExp = '#<h' . $lvl .
'>\s*<span.+?id="(.*?)">\s*(.*?)\s*</span>\s*</h' . $lvl . '>#m';
--
To view, visit https://gerrit.wikimedia.org/r/197044
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I942d41612f002558d9216c25f7855e93f7c73131
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikiArticleFeeds
Gerrit-Branch: master
Gerrit-Owner: Jack Phoenix <[email protected]>
Gerrit-Reviewer: Legoktm <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
