Ori.livneh has uploaded a new change for review. Change subject: Fudge relative expiry when it is exactly equal to the maximum ......................................................................
Fudge relative expiry when it is exactly equal to the maximum MemcachedBagOStuff::fixExpiry previously assumes that an expiry values greater than 2592000 but less than 1000000000 were caller mistakes, and normalized them to 2592000, the maximum permitted relative expiry. This fact, combined with the common use of 2592000 to mean "cache indefinitely", means we risk a periodic cache stampede every thirty days. Changes: - Do not attempt to correct outright stupidity ($expiry = 9999999, etc.) - If the requested expiry is exactly equal to 2592000, fudge it by subtracting a random quantity of seconds (up to 12 hours). Change-Id: If2ee54c7202f4cfc833bab74fd29f84611e44c9a --- M includes/objectcache/MemcachedBagOStuff.php 1 file changed, 14 insertions(+), 7 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/16/33816/1 -- To view, visit https://gerrit.wikimedia.org/r/33816 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If2ee54c7202f4cfc833bab74fd29f84611e44c9a Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Ori.livneh <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
