Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/199155
Change subject: Make page action overlay pointer position correctly.
......................................................................
Make page action overlay pointer position correctly.
This adds two new events.
The BannerImage fires a loaded event when it loads.
The Skin renders changed whenever something happens to the rendering of
the skin.
Bug: T91047
Change-Id: Ifcf3829b4d18748670ffd4de6979e54f1e17ce91
---
M javascripts/Skin.js
M javascripts/modules/bannerImage/BannerImage.js
M javascripts/modules/bannerImage/init.js
M javascripts/modules/tutorials/ContentOverlay.js
4 files changed, 14 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/55/199155/1
diff --git a/javascripts/Skin.js b/javascripts/Skin.js
index 12b27f0..9a6d6d5 100644
--- a/javascripts/Skin.js
+++ b/javascripts/Skin.js
@@ -136,6 +136,11 @@
$el.addClass( 'touch-events' );
}
$( '<div class="transparent-shield cloaked-element">'
).appendTo( '#mw-mf-page-center' );
+ /**
+ * @event changed
+ * Fired when appearance of skin changes.
+ */
+ this.emit( 'changed' );
},
/**
diff --git a/javascripts/modules/bannerImage/BannerImage.js
b/javascripts/modules/bannerImage/BannerImage.js
index 34e7fa6..82112df 100644
--- a/javascripts/modules/bannerImage/BannerImage.js
+++ b/javascripts/modules/bannerImage/BannerImage.js
@@ -87,7 +87,11 @@
.show();
self.resizeFrame();
-
+ /**
+ * @event loaded
+ * Fired when image has loaded and been rendered in
page.
+ */
+ self.emit( 'loaded' );
if ( !self.hasLoadedOnce ) {
self.hasLoadedOnce = true;
M.on( 'resize', function () {
diff --git a/javascripts/modules/bannerImage/init.js
b/javascripts/modules/bannerImage/init.js
index a481d56..1bc8426 100644
--- a/javascripts/modules/bannerImage/init.js
+++ b/javascripts/modules/bannerImage/init.js
@@ -4,6 +4,7 @@
var MobileViewBannerImageRepository = M.require(
'modules/bannerImage/MobileViewBannerImageRepository' ),
BannerImage = M.require( 'modules/bannerImage/BannerImage' ),
page = M.getCurrentPage(),
+ skin = M.require( 'skin' ),
repository,
bannerImage;
@@ -16,6 +17,7 @@
bannerImage = new BannerImage( {
repository: repository
} );
+ bannerImage.on( 'loaded', $.proxy( skin, 'emit', 'changed' ) );
bannerImage.insertBefore( '.pre-content' );
}
}( mw.mobileFrontend ) );
diff --git a/javascripts/modules/tutorials/ContentOverlay.js
b/javascripts/modules/tutorials/ContentOverlay.js
index 8f36fb1..ab6d2be 100644
--- a/javascripts/modules/tutorials/ContentOverlay.js
+++ b/javascripts/modules/tutorials/ContentOverlay.js
@@ -1,6 +1,7 @@
( function ( M, $ ) {
var ContentOverlay,
+ skin = M.require( 'skin' ),
Overlay = M.require( 'Overlay' );
/**
@@ -40,6 +41,7 @@
self.addPointerArrow( $target );
M.on( 'resize', $.proxy( self,
'refreshPointerArrow', options.target ) );
}, 0 );
+ skin.on( 'changed', $.proxy( this,
'refreshPointerArrow', options.target ) );
}
},
/**
--
To view, visit https://gerrit.wikimedia.org/r/199155
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifcf3829b4d18748670ffd4de6979e54f1e17ce91
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
