Dr0ptp4kt has submitted this change and it was merged.
Change subject: Avoid cache fragmenting URLs for Share a Fact shares
......................................................................
Avoid cache fragmenting URLs for Share a Fact shares
Use wprov=sfia1 for image card sharing
The Android app doesn't use the URL when sharing as text.
So, nothing to do there.
Bug: T90606
Change-Id: If1c84c8b1380092817b0bfae2d62d93747da0d25
---
M wikipedia/src/main/java/org/wikipedia/page/snippet/ShareHandler.java
1 file changed, 4 insertions(+), 1 deletion(-)
Approvals:
Dr0ptp4kt: Looks good to me, approved
jenkins-bot: Verified
diff --git
a/wikipedia/src/main/java/org/wikipedia/page/snippet/ShareHandler.java
b/wikipedia/src/main/java/org/wikipedia/page/snippet/ShareHandler.java
index 2af0a66..c9afebd 100644
--- a/wikipedia/src/main/java/org/wikipedia/page/snippet/ShareHandler.java
+++ b/wikipedia/src/main/java/org/wikipedia/page/snippet/ShareHandler.java
@@ -66,7 +66,10 @@
if (selectedText.length() >= minTextSnippetLength) {
String introText = activity.getString(R.string.snippet_share_intro,
title.getDisplayText(),
- title.getCanonicalUri() + "?source=app");
+ title.getCanonicalUri() + "?wprov=sfia1");
+ // For wprov=sfia1: see https://www.mediawiki.org/wiki/Provenance;
+ // introText is only used for image share
+
Bitmap resultBitmap = new SnippetImage(activity,
curPageFragment.getLeadImageBitmap(),
curPageFragment.getLeadImageFocusY(),
--
To view, visit https://gerrit.wikimedia.org/r/199140
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If1c84c8b1380092817b0bfae2d62d93747da0d25
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: BearND <[email protected]>
Gerrit-Reviewer: Brion VIBBER <[email protected]>
Gerrit-Reviewer: Dbrant <[email protected]>
Gerrit-Reviewer: Dr0ptp4kt <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
