Mobrovac has submitted this change and it was merged.

Change subject: Use standard If-Unmodified-Since header for conditional updates
......................................................................


Use standard If-Unmodified-Since header for conditional updates

http://tools.ietf.org/html/draft-ietf-httpbis-p4-conditional-22#page-16

Change-Id: I99dbf6fc5369ca1523b266e711cdc5e0a553b28f
---
M RestbaseUpdateJob.php
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Aaron Schulz: Looks good to me, but someone else must approve
  Mobrovac: Verified; Looks good to me, approved



diff --git a/RestbaseUpdateJob.php b/RestbaseUpdateJob.php
index e7a0a95..b72b029 100644
--- a/RestbaseUpdateJob.php
+++ b/RestbaseUpdateJob.php
@@ -246,7 +246,7 @@
                        'url'     => self::getPageTitleURL( $title, $latest ),
                        'headers' => array(
                                'X-Restbase-ParentRevision' => $previous,
-                               'X-Restbase-Timestamp' => $this->params['ts'],
+                               'If-Unmodified-Since' => date( 'r', intval( 
$this->params['ts'] ) ),
                                'Cache-control' => 'no-cache'
                        )
                ) );
@@ -278,7 +278,7 @@
                                'url'     => $url,
                                'headers' => array(
                                        'X-Restbase-Mode' => $mode,
-                                       'X-Restbase-Timestamp' => 
$this->params['ts'],
+                                       'If-Unmodified-Since' => date( 'r', 
intval( $this->params['ts'] ) ),
                                        'Cache-control' => 'no-cache'
                                )
                        );

-- 
To view, visit https://gerrit.wikimedia.org/r/199286
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I99dbf6fc5369ca1523b266e711cdc5e0a553b28f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/RestBaseUpdateJobs
Gerrit-Branch: master
Gerrit-Owner: GWicke <[email protected]>
Gerrit-Reviewer: Aaron Schulz <[email protected]>
Gerrit-Reviewer: Eevans <[email protected]>
Gerrit-Reviewer: Mobrovac <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to