Ejegg has uploaded a new change for review.
https://gerrit.wikimedia.org/r/199551
Change subject: Save gauge ranges, pull buttons up
......................................................................
Save gauge ranges, pull buttons up
Save and restore custom color ranges on the fraud gauge. Also pull
header buttons up to z-index 10 since they were getting covered by
the graph's -90px top margin.
Change-Id: I5012641b7dbca1973e31260923d74109aaa2edb8
---
M src/components/widgets/fraud-gauge/fraud-gauge.js
M src/css/style.css
2 files changed, 9 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/dash
refs/changes/51/199551/1
diff --git a/src/components/widgets/fraud-gauge/fraud-gauge.js
b/src/components/widgets/fraud-gauge/fraud-gauge.js
index 04482a7..c2a8487 100644
--- a/src/components/widgets/fraud-gauge/fraud-gauge.js
+++ b/src/components/widgets/fraud-gauge/fraud-gauge.js
@@ -50,8 +50,8 @@
self.gaugeValue = ko.observable(0);
self.filtersSelected = ko.observable(false);
self.queryStringSQL = ko.observable('This widget
hasn\'t been set up yet!');
- self.greenHighRange = ko.observable(17);
- self.redLowRange = ko.observable(68);
+ self.greenHighRange = ko.observable(
self.config.greenHighRange || 17 );
+ self.redLowRange = ko.observable(
self.config.redLowRange || 68 );
self.configSet =
ko.observable(Object.keys(self.config).length > 0);
self.populateChoices = function(){
@@ -279,7 +279,9 @@
queryString: self.queryString,
timeBreakout:
self.selectedTimePeriod().toString(),
selectedFilters:
self.queryRequest.selectedFilters,
- selectedSubFilters:
self.queryRequest.selectedSubFilters
+ selectedSubFilters:
self.queryRequest.selectedSubFilters,
+ greenHighRange: self.greenHighRange(),
+ redLowRange: self.redLowRange()
};
var chartDataCall = self.getChartData(
self.queryString );
diff --git a/src/css/style.css b/src/css/style.css
index b3e539c..9c9551d 100644
--- a/src/css/style.css
+++ b/src/css/style.css
@@ -457,6 +457,10 @@
padding:5px 5px 0 10px;
}
+.panel-heading button {
+ z-index:10;
+}
+
.panel-purple > .panel-heading + .panel-collapse .panel-body {
border-top-color: #5e668a;
}
--
To view, visit https://gerrit.wikimedia.org/r/199551
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5012641b7dbca1973e31260923d74109aaa2edb8
Gerrit-PatchSet: 1
Gerrit-Project: wikimedia/fundraising/dash
Gerrit-Branch: master
Gerrit-Owner: Ejegg <eeggles...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
