jenkins-bot has submitted this change and it was merged.
Change subject: Do not pass objects to Summary::addAutoCommentArgs
......................................................................
Do not pass objects to Summary::addAutoCommentArgs
This will probably not fix T93896, but it's just odd to stuff objects
in here. This gets rendered as a string anyway.
Bug: T93804
Bug: T93896
Change-Id: I5e30d9b9df53964587971a1649bf88deeedd8cbe
---
M repo/includes/Interactors/RedirectCreationInteractor.php
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Hoo man: Looks good to me, approved
jenkins-bot: Verified
diff --git a/repo/includes/Interactors/RedirectCreationInteractor.php
b/repo/includes/Interactors/RedirectCreationInteractor.php
index 7cf5fa9..517dadc 100644
--- a/repo/includes/Interactors/RedirectCreationInteractor.php
+++ b/repo/includes/Interactors/RedirectCreationInteractor.php
@@ -92,7 +92,7 @@
$this->checkEmpty( $fromId );
$summary = new Summary( 'wbcreateredirect' );
- $summary->addAutoCommentArgs( $fromId, $toId );
+ $summary->addAutoCommentArgs( $fromId->getSerialization(),
$toId->getSerialization() );
$redirect = new EntityRedirect( $fromId, $toId );
$this->saveRedirect( $redirect, $summary, $bot );
--
To view, visit https://gerrit.wikimedia.org/r/199625
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5e30d9b9df53964587971a1649bf88deeedd8cbe
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <[email protected]>
Gerrit-Reviewer: Aude <[email protected]>
Gerrit-Reviewer: Hoo man <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
