jenkins-bot has submitted this change and it was merged.
Change subject: Don't do stupid things with the recurring param
......................................................................
Don't do stupid things with the recurring param
This will fix the broken PayPal recurring thing. Sadly, I don't fully
understand
how it works. The paypal-recurring form hardcodes recurring='1', so we don't
need
to override anyway. Possibly the error had to do with setting to (int)1.
Bug: T93923
Change-Id: I22303a898da67c7e9b997ad2a2624d118ba37ff4
---
M paypal_gateway/paypal_gateway.body.php
1 file changed, 0 insertions(+), 7 deletions(-)
Approvals:
Ejegg: Looks good to me, approved
jenkins-bot: Verified
diff --git a/paypal_gateway/paypal_gateway.body.php
b/paypal_gateway/paypal_gateway.body.php
index d0d2876..222d756 100644
--- a/paypal_gateway/paypal_gateway.body.php
+++ b/paypal_gateway/paypal_gateway.body.php
@@ -32,13 +32,6 @@
protected function handleRequest() {
$this->getOutput()->allowClickjacking();
- if ( $this->getRequest()->getText( 'ffname', 'default' ) ===
'paypal-recurring' ) {
- // FIXME: do this in the form param harvesting step
- $this->adapter->addRequestData( array(
- 'recurring' => 1,
- ) );
- }
-
$this->handleDonationRequest();
}
--
To view, visit https://gerrit.wikimedia.org/r/199661
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I22303a898da67c7e9b997ad2a2624d118ba37ff4
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/DonationInterface
Gerrit-Branch: master
Gerrit-Owner: Awight <[email protected]>
Gerrit-Reviewer: AndyRussG <[email protected]>
Gerrit-Reviewer: Awight <[email protected]>
Gerrit-Reviewer: Ejegg <[email protected]>
Gerrit-Reviewer: Katie Horn <[email protected]>
Gerrit-Reviewer: Ssmith <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
