Jdlrobson has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/199813

Change subject: Make collections overlay less glitchy
......................................................................

Make collections overlay less glitchy

Disable scrolling whilst it is open

Bug: T93948
Change-Id: I0ebc22818e2f853a9589b2b964eaf0031ed08cbd
---
M resources/ext.gather.watchstar/CollectionsContentOverlay.js
M resources/ext.gather.watchstar/contentOverlay.less
2 files changed, 13 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Gather 
refs/changes/13/199813/1

diff --git a/resources/ext.gather.watchstar/CollectionsContentOverlay.js 
b/resources/ext.gather.watchstar/CollectionsContentOverlay.js
index 2f08bc6..f4a0c09 100644
--- a/resources/ext.gather.watchstar/CollectionsContentOverlay.js
+++ b/resources/ext.gather.watchstar/CollectionsContentOverlay.js
@@ -75,7 +75,13 @@
                        }
                },
                /** @inheritdoc */
+               show: function () {
+                       CollectionsContentOverlayBase.prototype.show.apply( 
this, arguments );
+                       $( 'html' ).addClass( 'gather-overlay-enabled' );
+               },
+               /** @inheritdoc */
                hide: function () {
+                       $( 'html' ).removeClass( 'gather-overlay-enabled' );
                        schema.log( {
                                eventName: 'hide'
                        } );
diff --git a/resources/ext.gather.watchstar/contentOverlay.less 
b/resources/ext.gather.watchstar/contentOverlay.less
index 5e315d2..d766605 100644
--- a/resources/ext.gather.watchstar/contentOverlay.less
+++ b/resources/ext.gather.watchstar/contentOverlay.less
@@ -3,6 +3,13 @@
 
 @backgroundHeight: 2.8em;
 @backgroundYOffset: 0.75em;
+.gather-overlay-enabled {
+       #mw-mf-page-center {
+         overflow: hidden;
+         display: block;
+       }
+}
+
 .overlay.collection-overlay {
        font-size: .9em;
        text-align: left;

-- 
To view, visit https://gerrit.wikimedia.org/r/199813
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0ebc22818e2f853a9589b2b964eaf0031ed08cbd
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Gather
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to