jenkins-bot has submitted this change and it was merged. Change subject: Make links in Echo's notification footer blue on hover ......................................................................
Make links in Echo's notification footer blue on hover Links on the notification footer, "View edit" / "View changes", needs to be blue instead of grey to be consistent with the Mediawiki interface. The link turns blue upon hovering, just the way it is currently set for other links on notifications like the page title. Bug: T57367 Change-Id: Ibaaff52b9d4bdfc5beca442e10734dd5cf8886d7 --- M modules/overlay/ext.echo.overlay.js 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Mattflaschen: Looks good to me, approved jenkins-bot: Verified diff --git a/modules/overlay/ext.echo.overlay.js b/modules/overlay/ext.echo.overlay.js index dfc14d2..7d5dfca 100644 --- a/modules/overlay/ext.echo.overlay.js +++ b/modules/overlay/ext.echo.overlay.js @@ -136,10 +136,10 @@ .addClass( 'mw-echo-grey-link' ); $li.hover( function() { - $( this ).find( '.mw-echo-title a' ).removeClass( 'mw-echo-grey-link' ); + $( this ).find( '.mw-echo-title a, .mw-echo-notification-footer a' ).removeClass( 'mw-echo-grey-link' ); }, function() { - $( this ).find( '.mw-echo-title a' ).addClass( 'mw-echo-grey-link' ); + $( this ).find( '.mw-echo-title a, .mw-echo-notification-footer a' ).addClass( 'mw-echo-grey-link' ); } ); // If there is a primary link, make the entire notification clickable. -- To view, visit https://gerrit.wikimedia.org/r/196593 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibaaff52b9d4bdfc5beca442e10734dd5cf8886d7 Gerrit-PatchSet: 3 Gerrit-Project: mediawiki/extensions/Echo Gerrit-Branch: master Gerrit-Owner: Tinaj1234 <tinajohnson.1...@gmail.com> Gerrit-Reviewer: 01tonythomas <01tonytho...@gmail.com> Gerrit-Reviewer: He7d3r <he7...@gmail.com> Gerrit-Reviewer: Legoktm <legoktm.wikipe...@gmail.com> Gerrit-Reviewer: Mattflaschen <mflasc...@wikimedia.org> Gerrit-Reviewer: Niharika29 <niharikakohl...@gmail.com> Gerrit-Reviewer: Qgil <q...@wikimedia.org> Gerrit-Reviewer: Quiddity <nwil...@wikimedia.org> Gerrit-Reviewer: Tinaj1234 <tinajohnson.1...@gmail.com> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits