jenkins-bot has submitted this change and it was merged.

Change subject: Made User::loadFromRow protected for sanity
......................................................................


Made User::loadFromRow protected for sanity

* The loading logic is complex enough without more possible
  entry points to cover
* No outside callers found

Change-Id: I7e9bace35afb0a540993423cf1da98381a516ac5
---
M includes/User.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/User.php b/includes/User.php
index 97eaa5c..46e3474 100644
--- a/includes/User.php
+++ b/includes/User.php
@@ -1226,7 +1226,7 @@
         *      user_groups             Array with groups out of the 
user_groups table
         *      user_properties         Array with properties out of the 
user_properties table
         */
-       public function loadFromRow( $row, $data = null ) {
+       protected function loadFromRow( $row, $data = null ) {
                $all = true;
                $passwordFactory = self::getPasswordFactory();
 

-- 
To view, visit https://gerrit.wikimedia.org/r/199827
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7e9bace35afb0a540993423cf1da98381a516ac5
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Aaron Schulz <[email protected]>
Gerrit-Reviewer: Legoktm <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to