Amire80 has uploaded a new change for review.
https://gerrit.wikimedia.org/r/199872
Change subject: [BrowserTest] Capture the whole Insert button in the screenshot
......................................................................
[BrowserTest] Capture the whole Insert button in the screenshot
Change-Id: I7551914d57adace5ceb385f16cc93e146e4774a7
---
M
modules/ve-mw/tests/browser/features/step_definitions/language_screenshot_steps.rb
M modules/ve-mw/tests/browser/features/support/pages/visual_editor_page.rb
2 files changed, 6 insertions(+), 5 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/72/199872/1
diff --git
a/modules/ve-mw/tests/browser/features/step_definitions/language_screenshot_steps.rb
b/modules/ve-mw/tests/browser/features/step_definitions/language_screenshot_steps.rb
index 91eb37b..9283a0d 100644
---
a/modules/ve-mw/tests/browser/features/step_definitions/language_screenshot_steps.rb
+++
b/modules/ve-mw/tests/browser/features/step_definitions/language_screenshot_steps.rb
@@ -188,7 +188,7 @@
Screenshot.capture(
@browser,
"#{@scenario.name}-#{ENV['LANGUAGE_SCREENSHOT_CODE']}.png",
- [@current_page.insert_indicator_down_element,
@current_page.insert_pull_down_element]
+ [@current_page.insert_button_element,
@current_page.insert_pull_down_element]
)
Screenshot.highlight(@current_page, @current_page.media_insert_menu_element)
@@ -196,7 +196,7 @@
Screenshot.capture(
@browser,
"VisualEditor_Media_Insert_Menu-#{ENV['LANGUAGE_SCREENSHOT_CODE']}.png",
- [@current_page.insert_indicator_down_element,
@current_page.insert_pull_down_element]
+ [@current_page.insert_button_element,
@current_page.insert_pull_down_element]
)
Screenshot.highlight(@current_page, @current_page.media_insert_menu_element,
'#FFFFFF')
@@ -205,7 +205,7 @@
Screenshot.capture(
@browser,
"VisualEditor_Template_Insert_Menu-#{ENV['LANGUAGE_SCREENSHOT_CODE']}.png",
- [@current_page.insert_indicator_down_element,
@current_page.insert_pull_down_element]
+ [@current_page.insert_button_element,
@current_page.insert_pull_down_element]
)
Screenshot.highlight(@current_page,
@current_page.template_insert_menu_element, '#FFFFFF')
@@ -214,7 +214,7 @@
Screenshot.capture(
@browser,
"VisualEditor_References_List_Insert_Menu-#{ENV['LANGUAGE_SCREENSHOT_CODE']}.png",
- [@current_page.insert_indicator_down_element,
@current_page.insert_pull_down_element]
+ [@current_page.insert_button_element,
@current_page.insert_pull_down_element]
)
Screenshot.highlight(@current_page,
@current_page.ref_list_insert_menu_element, '#FFFFFF')
@@ -223,7 +223,7 @@
Screenshot.capture(
@browser,
"VisualEditor_Formula_Insert_Menu-#{ENV['LANGUAGE_SCREENSHOT_CODE']}.png",
- [@current_page.insert_indicator_down_element,
@current_page.insert_pull_down_element]
+ [@current_page.insert_button_element,
@current_page.insert_pull_down_element]
)
end
diff --git
a/modules/ve-mw/tests/browser/features/support/pages/visual_editor_page.rb
b/modules/ve-mw/tests/browser/features/support/pages/visual_editor_page.rb
index 918966f..af6ec3b 100644
--- a/modules/ve-mw/tests/browser/features/support/pages/visual_editor_page.rb
+++ b/modules/ve-mw/tests/browser/features/support/pages/visual_editor_page.rb
@@ -72,6 +72,7 @@
span(:insert_citation, css: '.ve-ui-nodeDialog > div:nth-child(1) >
div:nth-child(1) > div:nth-child(3) > div:nth-child(1) > a:nth-child(1) >
span:nth-child(2)
')
span(:insert_indicator, text: 'Insert')
+ div(:insert_button, class: 've-test-toolbar-insert')
span(:insert_indicator_down, css: '.ve-test-toolbar-insert
.oo-ui-indicator-down')
a(:insert_more_fewer, css: '.ve-test-toolbar-insert
.oo-ui-tool-name-more-fewer .oo-ui-tool-link')
div(:insert_pull_down, css: '.ve-test-toolbar-insert
.oo-ui-clippableElement-clippable')
--
To view, visit https://gerrit.wikimedia.org/r/199872
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7551914d57adace5ceb385f16cc93e146e4774a7
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Amire80 <amir.ahar...@mail.huji.ac.il>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
