Se4598 has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/199889

Change subject: Do API queries after API_DELAY
......................................................................

Do API queries after API_DELAY

Based on the comments this is what it supposed to be.
mw.popups.render.article does the API-queries on init, so do that after
the API_DELAY-timer fired.

Change-Id: Ia235cbe1eb86fc774edda84208d320843401624e
---
M resources/ext.popups.renderer.js
1 file changed, 5 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Popups 
refs/changes/89/199889/1

diff --git a/resources/ext.popups.renderer.js b/resources/ext.popups.renderer.js
index 0781ad2..142889d 100644
--- a/resources/ext.popups.renderer.js
+++ b/resources/ext.popups.renderer.js
@@ -99,12 +99,13 @@
                                        mw.popups.render.openPopup( link, event 
);
                                } );
                } else {
-                       // TODO: check for link type and call correct renderer
-                       // There is only one popup type so it isn't necessary 
right now
-                       var cachePopup = mw.popups.render.article.init( link );
-
+                       // Wait for timer before making API queries and showing 
hovercard
                        mw.popups.render.openTimer = mw.popups.render.wait( 
mw.popups.render.API_DELAY )
                                .done( function () {
+                                       // TODO: check for link type and call 
correct renderer
+                                       // There is only one popup type right 
now so it isn't necessary
+                                       var cachePopup = 
mw.popups.render.article.init( link );
+
                                        mw.popups.render.openTimer = 
mw.popups.render.wait( mw.popups.render.POPUP_DELAY - 
mw.popups.render.API_DELAY );
 
                                        $.when( mw.popups.render.openTimer, 
cachePopup ).done( function () {

-- 
To view, visit https://gerrit.wikimedia.org/r/199889
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia235cbe1eb86fc774edda84208d320843401624e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Popups
Gerrit-Branch: master
Gerrit-Owner: Se4598 <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to