Matthias Mullie has uploaded a new change for review.
https://gerrit.wikimedia.org/r/199896
Change subject: First store workflow, then the rest
......................................................................
First store workflow, then the rest
ReferenceRecorder (on of the post listeners) will need content
in HTML, for which it will need to retrieve Collection & Title,
to figure out what page to parse against.
Since workflow hasn't yet been stored, this fails.
Obvious solution here is to first store workflow. However, the
comment explicitly said it was there for a reason.
I'm not entirely certain that reason is still valid. I tried
creating new topics & stuff, still seemed to work just fine.
I'm hoping whoever reviews this, remembers exactly why this was!
If we can't merge this, we could remove referenceloader from
post listeners if storage format is not html.
Bug: T94025
Change-Id: Ic82a64207dd92f5461fd9651ace4b444478095d6
---
M includes/Block/TopicList.php
1 file changed, 1 insertion(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Flow
refs/changes/96/199896/1
diff --git a/includes/Block/TopicList.php b/includes/Block/TopicList.php
index 899144c..26ebfe9 100644
--- a/includes/Block/TopicList.php
+++ b/includes/Block/TopicList.php
@@ -149,6 +149,7 @@
'first-post' => $this->firstPost,
);
+ $storage->put( $this->topicWorkflow, $metadata );
$storage->put( $this->topicListEntry, $metadata );
$storage->put( $this->topicTitle, $metadata );
if ( $this->firstPost !== null ) {
@@ -156,10 +157,6 @@
'reply-to' => $this->topicTitle
) );
}
- // must be last because this will trigger
OccupationController::ensureFlowRevision
- // to create the page within topic namespace, that will try and
render, so the above
- // stuff needs to be in cache at least.
- $storage->put( $this->topicWorkflow, $metadata );
$output = array(
'topic-page' =>
$this->topicWorkflow->getArticleTitle()->getPrefixedText(),
--
To view, visit https://gerrit.wikimedia.org/r/199896
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic82a64207dd92f5461fd9651ace4b444478095d6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: Matthias Mullie <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
