jenkins-bot has submitted this change and it was merged.
Change subject: Bug fix in processRefs DOM pass refactoring
......................................................................
Bug fix in processRefs DOM pass refactoring
Change-Id: Icd4ce9919de4ba50e5186b8ec3b1923ae9eeb18e
---
M lib/dom.processRefs.js
M lib/ext.Cite.js
2 files changed, 3 insertions(+), 3 deletions(-)
Approvals:
Arlolra: Looks good to me, approved
jenkins-bot: Verified
diff --git a/lib/dom.processRefs.js b/lib/dom.processRefs.js
index 4a2b140..18a0b62 100644
--- a/lib/dom.processRefs.js
+++ b/lib/dom.processRefs.js
@@ -18,7 +18,7 @@
var typeOf = child.getAttribute('typeof');
if
((/(?:^|\s)mw:Extension\/ref\/Marker(?=$|\s)/).test(typeOf)) {
cite.references.extractRefFromNode(child,
- _processRefs.bind(null), referencesId,
referencesGroup, nestedRefsHTML);
+ _processRefs.bind(null, cite),
referencesId, referencesGroup, nestedRefsHTML);
} else if (child.childNodes.length > 0) {
_processRefsInReferences(cite,
child, referencesId, referencesGroup,
nestedRefsHTML);
@@ -36,7 +36,7 @@
if (DU.isElt(child)) {
var typeOf = child.getAttribute('typeof');
if
((/(?:^|\s)mw:Extension\/ref\/Marker(?=$|\s)/).test(typeOf)) {
- cite.references.extractRefFromNode(child,
_processRefs.bind(null));
+ cite.references.extractRefFromNode(child,
_processRefs.bind(null, cite));
} else if
((/(?:^|\s)mw:Extension\/references(?=$|\s)/).test(typeOf)) {
var referencesId = child.getAttribute("about");
var referencesGroup =
DU.getDataParsoid(child).group;
diff --git a/lib/ext.Cite.js b/lib/ext.Cite.js
index 5c2a888..0e11b86 100644
--- a/lib/ext.Cite.js
+++ b/lib/ext.Cite.js
@@ -379,7 +379,7 @@
if (dp.hasRefInRef) {
var html = DU.parseHTML(content).body;
- refInRefProcessor(this, html);
+ refInRefProcessor(html);
content = DU.serializeChildren(html);
}
--
To view, visit https://gerrit.wikimedia.org/r/199937
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icd4ce9919de4ba50e5186b8ec3b1923ae9eeb18e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/parsoid
Gerrit-Branch: master
Gerrit-Owner: Subramanya Sastry <[email protected]>
Gerrit-Reviewer: Arlolra <[email protected]>
Gerrit-Reviewer: Cscott <[email protected]>
Gerrit-Reviewer: Marcoil <[email protected]>
Gerrit-Reviewer: Subramanya Sastry <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
