jenkins-bot has submitted this change and it was merged.
Change subject: Hygiene: Remove 'mw-less testing' lines and empty comments
......................................................................
Hygiene: Remove 'mw-less testing' lines and empty comments
I don't think anyone is really trying to test Flow without MW.
Change-Id: I657d267e39706b8ac2274a24e589dcb32254ec50
---
M modules/engine/components/flow-registry.js
M modules/engine/misc/flow-api.js
M modules/engine/misc/flow-baseconvert.js
M modules/engine/misc/flow-handlebars.js
4 files changed, 0 insertions(+), 14 deletions(-)
Approvals:
EBernhardson: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/engine/components/flow-registry.js
b/modules/engine/components/flow-registry.js
index 08967da..3b2a949 100644
--- a/modules/engine/components/flow-registry.js
+++ b/modules/engine/components/flow-registry.js
@@ -8,7 +8,6 @@
*/
( function ( $, mw ) {
- window.mw = window.mw || {}; // mw-less testing
mw.flow = mw.flow || {}; // create mw.flow globally
var _componentRegistry = new OO.Registry();
diff --git a/modules/engine/misc/flow-api.js b/modules/engine/misc/flow-api.js
index a35efe3..229a255 100644
--- a/modules/engine/misc/flow-api.js
+++ b/modules/engine/misc/flow-api.js
@@ -1,9 +1,3 @@
-/*!
- *
- */
-
-window.mw = window.mw || {}; // mw-less testing
-
( function ( mw, $ ) {
mw.flow = mw.flow || {}; // create mw.flow globally
diff --git a/modules/engine/misc/flow-baseconvert.js
b/modules/engine/misc/flow-baseconvert.js
index 055f8a0..ae6e755 100644
--- a/modules/engine/misc/flow-baseconvert.js
+++ b/modules/engine/misc/flow-baseconvert.js
@@ -1,9 +1,3 @@
-/*!
- *
- */
-
-window.mw = window.mw || {}; // mw-less testing
-
( function ( mw, $ ) {
mw.flow = mw.flow || {}; // create mw.flow globally
diff --git a/modules/engine/misc/flow-handlebars.js
b/modules/engine/misc/flow-handlebars.js
index 0d9d461..b3f2192 100644
--- a/modules/engine/misc/flow-handlebars.js
+++ b/modules/engine/misc/flow-handlebars.js
@@ -3,7 +3,6 @@
*/
( function ( mw, $, moment, Handlebars ) {
- window.mw = window.mw || {}; // mw-less testing
mw.flow = mw.flow || {}; // create mw.flow globally
var _tplcache = {},
--
To view, visit https://gerrit.wikimedia.org/r/200046
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I657d267e39706b8ac2274a24e589dcb32254ec50
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: Mattflaschen <[email protected]>
Gerrit-Reviewer: EBernhardson <[email protected]>
Gerrit-Reviewer: Matthias Mullie <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
