Awight has uploaded a new change for review.
https://gerrit.wikimedia.org/r/200096
Change subject: TODO Less special-casing in DataValidator
......................................................................
TODO Less special-casing in DataValidator
Change-Id: I2049be40bf41c3db048a0225ac711aefd5ed585e
---
M gateway_common/DataValidator.php
1 file changed, 1 insertion(+), 0 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/DonationInterface
refs/changes/96/200096/1
diff --git a/gateway_common/DataValidator.php b/gateway_common/DataValidator.php
index 111b3ae..52ae1ea 100644
--- a/gateway_common/DataValidator.php
+++ b/gateway_common/DataValidator.php
@@ -347,6 +347,7 @@
}
$result = null;
// Handle special cases.
+ // TODO: Pass $gateway and $results,
eliminating special cases?
switch ( $validation_function ) {
case 'validate_amount':
if (
self::checkValidationPassed( array( 'currency_code', 'gateway' ), $results ) ){
--
To view, visit https://gerrit.wikimedia.org/r/200096
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2049be40bf41c3db048a0225ac711aefd5ed585e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/DonationInterface
Gerrit-Branch: master
Gerrit-Owner: Awight <awi...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
