Dzahn has uploaded a new change for review.
https://gerrit.wikimedia.org/r/200103
Change subject: wikimetrics: lint
......................................................................
wikimetrics: lint
3 x double quoted string containing no variables
4 x indentation of => is not properly aligned
1 x ensure found on line but it's not the first attribute
puppet-lint 1.1.0
Change-Id: I60588381ef15d22d25a90d2f75e8e1fa5c1680c5
---
M manifests/role/wikimetrics.pp
1 file changed, 6 insertions(+), 6 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/operations/puppet
refs/changes/03/200103/1
diff --git a/manifests/role/wikimetrics.pp b/manifests/role/wikimetrics.pp
index 88c6ea4..ff16971 100644
--- a/manifests/role/wikimetrics.pp
+++ b/manifests/role/wikimetrics.pp
@@ -168,11 +168,11 @@
# Setup mysql, put data in /srv
class { 'mysql::server':
- config_hash => {
+ config_hash => {
'datadir' => '/srv/mysql'
},
- before => Class['::wikimetrics::database'],
- require => Labs_lvm::Volume['second-local-disk']
+ before => Class['::wikimetrics::database'],
+ require => Labs_lvm::Volume['second-local-disk']
}
class { '::wikimetrics':
@@ -234,7 +234,7 @@
var_directory => $var_directory,
public_subdirectory => $public_subdirectory,
- require => Labs_lvm::Volume['second-local-disk'],
+ require => Labs_lvm::Volume['second-local-disk'],
}
# Run the wikimetrics/scripts/install script
@@ -270,7 +270,7 @@
class { '::redis':
dir => $redis_dir,
dbfilename => $redis_dbfilename,
- saves => [ "900 1", "300 10", "60 20" ],
+ saves => [ '900 1', '300 10', '60 20' ],
stop_writes_on_bgsave_error => true,
}
@@ -299,6 +299,7 @@
$backup_ensure = 'absent'
}
class { '::wikimetrics::backup':
+ ensure => $backup_ensure,
destination => "/data/project/wikimetrics/backup/${::hostname}",
db_user => $db_user_wikimetrics,
db_pass => $db_pass_wikimetrics,
@@ -307,7 +308,6 @@
redis_db_file => "${redis_dir}/${redis_dbfilename}",
public_files => $public_directory,
keep_days => 10,
- ensure => $backup_ensure,
}
# Link aggregated projectcounts files to public directory
--
To view, visit https://gerrit.wikimedia.org/r/200103
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I60588381ef15d22d25a90d2f75e8e1fa5c1680c5
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Dzahn <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
