UltrasonicNXT has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/200155

Change subject: Ensure reply button moves user to correct place
......................................................................

Ensure reply button moves user to correct place

As per bug report on github

Change-Id: Idc2578f76449f51a199fb2e5dcfa42eec873184d
---
M Comments.php
M CommentsHooks.php
M CommentsPage.php
3 files changed, 4 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Comments 
refs/changes/55/200155/1

diff --git a/Comments.php b/Comments.php
index 7337a21..9a20af8 100644
--- a/Comments.php
+++ b/Comments.php
@@ -24,7 +24,7 @@
 $wgExtensionCredits['parserhook'][] = array(
        'path' => __FILE__,
        'name' => 'Comments',
-       'version' => '4.0.1',
+       'version' => '4.0.2',
        'author' => array( 'David Pean', 'Misza', 'Jack Phoenix', 'Adam 
Carter/UltrasonicNXT' ),
        'descriptionmsg' => 'comments-desc',
        'url' => 'https://www.mediawiki.org/wiki/Extension:Comments'
diff --git a/CommentsHooks.php b/CommentsHooks.php
index 3c37e80..7cf0a45 100644
--- a/CommentsHooks.php
+++ b/CommentsHooks.php
@@ -85,6 +85,7 @@
                $output = '<div class="comments-body">';
 
                if ( $wgCommentsSortDescending ) { // form before comments
+                       $output .= '<a id="end" name="end" rel="nofollow"></a>';
                        if ( !wfReadOnly() ) {
                                $output .= $commentsPage->displayForm();
                        } else {
@@ -104,6 +105,7 @@
                        } else {
                                $output .= wfMessage( 'comments-db-locked' 
)->parse();
                        }
+                       $output .= '<a id="end" name="end" rel="nofollow"></a>';
                }
 
                $output .= '</div>'; // div.comments-body
diff --git a/CommentsPage.php b/CommentsPage.php
index 174dabf..96e2d5c 100644
--- a/CommentsPage.php
+++ b/CommentsPage.php
@@ -478,7 +478,7 @@
             }
             $output .= $pager;
         }
-        $output .= '<a id="end" name="end" rel="nofollow"></a>';
+
         return $output;
     }
 

-- 
To view, visit https://gerrit.wikimedia.org/r/200155
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Idc2578f76449f51a199fb2e5dcfa42eec873184d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Comments
Gerrit-Branch: master
Gerrit-Owner: UltrasonicNXT <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to