Trevor Parscal has uploaded a new change for review.
https://gerrit.wikimedia.org/r/200214
Change subject: Don't assume indicators are full-height
......................................................................
Don't assume indicators are full-height
Changes in the OOjs UI layout of elements within buttons has exposed the
assumptiont that an indicator is always full height - causing
CategoryPopupWidget to be vertically misaligned.
Instead, measure both the top and the height to figure out where the bottom is.
Bug: T94114
Change-Id: I05ddbeb42b49dab925fe9b46caf12c6201e68441
---
M modules/ve-mw/ui/widgets/ve.ui.MWCategoryPopupWidget.js
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/14/200214/1
diff --git a/modules/ve-mw/ui/widgets/ve.ui.MWCategoryPopupWidget.js
b/modules/ve-mw/ui/widgets/ve.ui.MWCategoryPopupWidget.js
index 7ab676c..752fb9e 100644
--- a/modules/ve-mw/ui/widgets/ve.ui.MWCategoryPopupWidget.js
+++ b/modules/ve-mw/ui/widgets/ve.ui.MWCategoryPopupWidget.js
@@ -188,7 +188,7 @@
// Align to the middle of the indicator
pos.left += item.$indicator.width() / 2;
// Position below the indicator
- pos.top += item.$indicator.height();
+ pos.top += item.$indicator.position().top + item.$indicator.height();
this.$element.css( pos );
this.setSize( this.$menu.outerWidth( true ), this.$menu.outerHeight(
true ) );
--
To view, visit https://gerrit.wikimedia.org/r/200214
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I05ddbeb42b49dab925fe9b46caf12c6201e68441
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Trevor Parscal <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
