jenkins-bot has submitted this change and it was merged.
Change subject: Don't access context in SpecialPage::__construct(), it's not
set yet
......................................................................
Don't access context in SpecialPage::__construct(), it's not set yet
Change-Id: I8bf84990ea9c6c16dd08a23c426e6909752f7ad8
---
M includes/specials/SpecialGather.php
1 file changed, 10 insertions(+), 13 deletions(-)
Approvals:
Jdlrobson: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/specials/SpecialGather.php
b/includes/specials/SpecialGather.php
index 3368353..fe717e0 100644
--- a/includes/specials/SpecialGather.php
+++ b/includes/specials/SpecialGather.php
@@ -21,18 +21,6 @@
public function __construct() {
parent::__construct( 'Gather' );
- $out = $this->getOutput();
- $out->addModules(
- array(
- 'ext.gather.special',
- )
- );
- $out->addModuleStyles( array(
- 'mediawiki.ui.anchor',
- 'mediawiki.ui.icon',
- 'ext.gather.icons',
- 'ext.gather.styles',
- ) );
}
/**
@@ -41,7 +29,16 @@
* @param string $subpage
*/
public function execute( $subpage ) {
-
+ $out = $this->getOutput();
+ $out->addModules( array(
+ 'ext.gather.special',
+ ) );
+ $out->addModuleStyles( array(
+ 'mediawiki.ui.anchor',
+ 'mediawiki.ui.icon',
+ 'ext.gather.icons',
+ 'ext.gather.styles',
+ ) );
if ( preg_match( '/^$/', $subpage ) ) {
// Root subpage. User owned collections.
// For listing own lists, you need to be logged in
--
To view, visit https://gerrit.wikimedia.org/r/200112
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8bf84990ea9c6c16dd08a23c426e6909752f7ad8
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Gather
Gerrit-Branch: master
Gerrit-Owner: Legoktm <[email protected]>
Gerrit-Reviewer: Jdlrobson <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits