jenkins-bot has submitted this change and it was merged.
Change subject: Add @ as a sequence to open mentions.
......................................................................
Add @ as a sequence to open mentions.
This allows you to add mentions fluidly, without ever using the mouse.
However, it also means you can't type the at sign normally. We'll see
if this is an issue. The workaround is just to paste it in.
Bug: T93324
Change-Id: Ie9299768e1ace0c50ccb62599e53ff794f7150ca
---
M Resources.php
A modules/editor/editors/visualeditor/mw.flow.ve.SequenceRegistry.js
2 files changed, 13 insertions(+), 0 deletions(-)
Approvals:
EBernhardson: Looks good to me, approved
jenkins-bot: Verified
diff --git a/Resources.php b/Resources.php
index 4bc5731..6b5b095 100644
--- a/Resources.php
+++ b/Resources.php
@@ -444,6 +444,7 @@
'editor/editors/visualeditor/ui/contextitem/mw.flow.ve.ui.MentionContextItem.js',
'editor/editors/visualeditor/ui/widgets/mw.flow.ve.ui.MentionTargetInputWidget.js',
'editor/editors/visualeditor/mw.flow.ve.CommandRegistry.js',
+
'editor/editors/visualeditor/mw.flow.ve.SequenceRegistry.js',
),
'styles' => array(
'editor/editors/visualeditor/mw.flow.ve.Target.less',
diff --git a/modules/editor/editors/visualeditor/mw.flow.ve.SequenceRegistry.js
b/modules/editor/editors/visualeditor/mw.flow.ve.SequenceRegistry.js
new file mode 100644
index 0000000..8a2f1c0
--- /dev/null
+++ b/modules/editor/editors/visualeditor/mw.flow.ve.SequenceRegistry.js
@@ -0,0 +1,12 @@
+( function ( ve ) {
+ 'use strict';
+
+ ve.ui.sequenceRegistry.register(
+ new ve.ui.Sequence(
+ 'flowAtCharMention',
+ 'flowMention',
+ '@',
+ 1
+ )
+ );
+} ( ve ) );
--
To view, visit https://gerrit.wikimedia.org/r/198182
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie9299768e1ace0c50ccb62599e53ff794f7150ca
Gerrit-PatchSet: 6
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: Mattflaschen <[email protected]>
Gerrit-Reviewer: EBernhardson <[email protected]>
Gerrit-Reviewer: Mattflaschen <[email protected]>
Gerrit-Reviewer: Matthias Mullie <[email protected]>
Gerrit-Reviewer: SG <[email protected]>
Gerrit-Reviewer: TheDJ <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
