John Erling Blad has submitted this change and it was merged. Change subject: ClaimList now uses HashArray rather then HashableObjectStorage ......................................................................
ClaimList now uses HashArray rather then HashableObjectStorage In retrospect we currently actually do not need efficient by-guid lookup since we can just get away with looping over all claims and then selecting the one with the correct guid. Leaving it as it is for now since its quite possible we run into a use case for it soonish. If we dont it can be changed back to use HashableObjectStorage if we want to make it as simple as possible Change-Id: Id7f0aa283e368007a4f88bee943db6f17a881a12 --- M lib/WikibaseLib.hooks.php M lib/WikibaseLib.php M lib/includes/HashArray.php M lib/includes/claim/ClaimList.php M lib/includes/claim/ClaimListAccess.php M lib/includes/claim/Claims.php M lib/includes/entity/EntityObject.php M lib/tests/phpunit/claim/ClaimListTest.php A lib/tests/phpunit/hasharray/HashArrayElement.php R lib/tests/phpunit/hasharray/HashArrayTest.php A lib/tests/phpunit/hasharray/HashArrayWithDuplicatesTest.php A lib/tests/phpunit/hasharray/HashArrayWithoutDuplicatesTest.php 12 files changed, 602 insertions(+), 85 deletions(-) Approvals: John Erling Blad: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/33827 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id7f0aa283e368007a4f88bee943db6f17a881a12 Gerrit-PatchSet: 3 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Jeroen De Dauw <[email protected]> Gerrit-Reviewer: Daniel Kinzler <[email protected]> Gerrit-Reviewer: Daniel Werner <[email protected]> Gerrit-Reviewer: Jens Ohlig <[email protected]> Gerrit-Reviewer: Jeroen De Dauw <[email protected]> Gerrit-Reviewer: John Erling Blad <[email protected]> Gerrit-Reviewer: Tobias Gritschacher <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
