Divec has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/200536

Change subject: WIP: Allow cursoring into/out of tables
......................................................................

WIP: Allow cursoring into/out of tables

ve.ce.TableNode
* Remove ce=false on tables (so you can cursor into a table, and your selection
  gets fixed up into a table selection).

Change-Id: Ibfb6ee8321c220e51a62dc397d7d74a8cba495ca
TODO: Implement cursoring out of a table.
---
M src/ce/nodes/ve.ce.TableNode.js
1 file changed, 1 insertion(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor 
refs/changes/36/200536/1

diff --git a/src/ce/nodes/ve.ce.TableNode.js b/src/ce/nodes/ve.ce.TableNode.js
index 4f9193f..b964c27 100644
--- a/src/ce/nodes/ve.ce.TableNode.js
+++ b/src/ce/nodes/ve.ce.TableNode.js
@@ -25,8 +25,7 @@
 
        // DOM changes
        this.$element
-               .addClass( 've-ce-tableNode' )
-               .prop( 'contentEditable', 'false' );
+               .addClass( 've-ce-tableNode' );
 };
 
 /* Inheritance */

-- 
To view, visit https://gerrit.wikimedia.org/r/200536
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibfb6ee8321c220e51a62dc397d7d74a8cba495ca
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Divec <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to