jenkins-bot has submitted this change and it was merged.
Change subject: Remove unused EntityStore::get call
......................................................................
Remove unused EntityStore::get call
Change-Id: I6e694dd6d3501f044671c87ae33d29011acfb6e2
(cherry picked from commit da4a2d5ef4f7b5318b5d2c28b8c20a1b98848df1)
---
M lib/resources/jquery.wikibase/snakview/snakview.js
1 file changed, 12 insertions(+), 14 deletions(-)
Approvals:
Aude: Looks good to me, approved
jenkins-bot: Verified
diff --git a/lib/resources/jquery.wikibase/snakview/snakview.js
b/lib/resources/jquery.wikibase/snakview/snakview.js
index ca328aa..d4ceb37 100644
--- a/lib/resources/jquery.wikibase/snakview/snakview.js
+++ b/lib/resources/jquery.wikibase/snakview/snakview.js
@@ -265,22 +265,20 @@
$( '<div/>' ).append( $( '<span/>' ).addClass(
'mw-small-spinner' ) )
);
- self.options.entityStore.get( entityId ).done(
function( entity ) {
- self.updateVariation();
- self.drawSnakTypeSelector();
- self.drawVariation();
+ self.updateVariation();
+ self.drawSnakTypeSelector();
+ self.drawVariation();
- self._trigger( 'change' );
+ self._trigger( 'change' );
- // Since it takes a while for the value view to
gather its data from the API,
- // the property might not be valid anymore
aborting the rendering of the value
- // view.
- if( self._tabToValueView && self._variation ) {
- $( self._variation ).one( 'afterdraw',
function() {
- self._variation.focus();
- } );
- }
- } );
+ // Since it takes a while for the value view to gather
its data from the API,
+ // the property might not be valid anymore aborting the
rendering of the value
+ // view.
+ if( self._tabToValueView && self._variation ) {
+ $( self._variation ).one( 'afterdraw',
function() {
+ self._variation.focus();
+ } );
+ }
} );
},
--
To view, visit https://gerrit.wikimedia.org/r/199971
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6e694dd6d3501f044671c87ae33d29011acfb6e2
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: wmf/1.25wmf22
Gerrit-Owner: Hoo man <[email protected]>
Gerrit-Reviewer: Adrian Lang <[email protected]>
Gerrit-Reviewer: Aude <[email protected]>
Gerrit-Reviewer: Hoo man <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
