MarkTraceur has uploaded a new change for review.
https://gerrit.wikimedia.org/r/200753
Change subject: Fix tabindex and order of buttons
......................................................................
Fix tabindex and order of buttons
I reversed the order of the buttons because positive tabindices are
frowned upon.
Bug: T64763
Change-Id: I783129fa0f824ef7fc81015454d2dcbd38f60da4
---
M frontend/specialpages/SpecialMWOAuth.php
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/OAuth
refs/changes/53/200753/1
diff --git a/frontend/specialpages/SpecialMWOAuth.php
b/frontend/specialpages/SpecialMWOAuth.php
index 9f4a933..4e3d7ba 100644
--- a/frontend/specialpages/SpecialMWOAuth.php
+++ b/frontend/specialpages/SpecialMWOAuth.php
@@ -355,12 +355,12 @@
$form->addHeaderText( $this->msg( 'mwoauth-form-legal'
)->text() );
$form->suppressDefaultSubmit();
+ $form->addButton( 'accept',
+ wfMessage( 'mwoauth-form-button-approve' )->text(),
null,
+ array( 'class' => 'mw-mwoauth-authorize-button
mw-ui-button mw-ui-constructive', 'tabindex' => 0 ) );
$form->addButton( 'cancel',
wfMessage( 'mwoauth-form-button-cancel' )->text(), null,
array( 'class' => 'mw-mwoauth-authorize-button
mw-ui-button mw-ui-quiet' ) );
- $form->addButton( 'accept',
- wfMessage( 'mwoauth-form-button-approve' )->text(),
null,
- array( 'class' => 'mw-mwoauth-authorize-button
mw-ui-button mw-ui-constructive' ) );
$privacyMessage = MWOAuthUtils::getSiteMessage(
'mwoauth-form-privacypolicy-link' );
$form->addFooterText( wfMessage( $privacyMessage )->parse() );
--
To view, visit https://gerrit.wikimedia.org/r/200753
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I783129fa0f824ef7fc81015454d2dcbd38f60da4
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/OAuth
Gerrit-Branch: master
Gerrit-Owner: MarkTraceur <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
