jenkins-bot has submitted this change and it was merged. Change subject: Fix more JS errors ......................................................................
Fix more JS errors Same as https://gerrit.wikimedia.org/r/#/c/200518/ 'value=""' should be used, not 'value=' Change-Id: I83839dfae0359f3d7b092f522fe879ddeda03c68 --- M modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.special.js 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Matthias Mullie: Looks good to me, approved jenkins-bot: Verified diff --git a/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.special.js b/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.special.js index 88ef64a..ba1d371 100644 --- a/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.special.js +++ b/modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.special.js @@ -422,7 +422,7 @@ } ); // Disable the dividers - $( '#articleFeedbackv5-sort-select option[value=]' ).attr( 'disabled', true ); + $( '#articleFeedbackv5-sort-select option[value=""]' ).attr( 'disabled', true ); // Show more $( '#articleFeedbackv5-show-more' ).bind( 'click', function( e ) { -- To view, visit https://gerrit.wikimedia.org/r/200638 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I83839dfae0359f3d7b092f522fe879ddeda03c68 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/ArticleFeedbackv5 Gerrit-Branch: master Gerrit-Owner: UltrasonicNXT <adamr_car...@btinternet.com> Gerrit-Reviewer: Bartosz Dziewoński <matma....@gmail.com> Gerrit-Reviewer: Matthias Mullie <mmul...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
