Filippo Giunchedi has submitted this change and it was merged.
Change subject: mediawiki: fix dsh group lookup
......................................................................
mediawiki: fix dsh group lookup
Following I6ddd5df7e239969caa59eb88ada1f5cfa0fe195b we can't do an exact
match anymore.
Change-Id: I4224aa33797dd42d4fc4d41ef970f283039c260b
---
M modules/nagios_common/files/check_commands/check_dsh_groups
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Filippo Giunchedi: Verified; Looks good to me, approved
diff --git a/modules/nagios_common/files/check_commands/check_dsh_groups
b/modules/nagios_common/files/check_commands/check_dsh_groups
index cf6f494..0170088 100755
--- a/modules/nagios_common/files/check_commands/check_dsh_groups
+++ b/modules/nagios_common/files/check_commands/check_dsh_groups
@@ -15,7 +15,8 @@
echo "dsh group $GROUP not found"
exit 3
fi
- if [ "`grep $HOST $FILE`" != "$HOST" ] ; then
+
+ if ! grep -q "^${HOST}\." "${FILE}"; then
echo "Host $HOST is not in $GROUP dsh group"
exit 2
fi
--
To view, visit https://gerrit.wikimedia.org/r/200824
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4224aa33797dd42d4fc4d41ef970f283039c260b
Gerrit-PatchSet: 3
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Giuseppe Lavagetto <glavage...@wikimedia.org>
Gerrit-Reviewer: Filippo Giunchedi <fgiunch...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
