jenkins-bot has submitted this change and it was merged.
Change subject: Make "unknown value" and "no value" snaks in diffs italic
......................................................................
Make "unknown value" and "no value" snaks in diffs italic
This simply reuses the existing CSS class names.
Bug: T63662
Change-Id: I51618f059ed1529149de33ea482fa698212755b3
---
M lib/includes/formatters/MessageSnakFormatter.php
M lib/tests/phpunit/formatters/MessageSnakFormatterTest.php
2 files changed, 21 insertions(+), 2 deletions(-)
Approvals:
Adrian Lang: Looks good to me, approved
jenkins-bot: Verified
diff --git a/lib/includes/formatters/MessageSnakFormatter.php
b/lib/includes/formatters/MessageSnakFormatter.php
index a1ddbb4..52917c3 100644
--- a/lib/includes/formatters/MessageSnakFormatter.php
+++ b/lib/includes/formatters/MessageSnakFormatter.php
@@ -2,6 +2,7 @@
namespace Wikibase\Lib;
+use Html;
use InvalidArgumentException;
use Message;
use RuntimeException;
@@ -14,8 +15,17 @@
*
* @license GPL 2+
* @author Daniel Kinzler
+ * @author Thiemo Mättig
*/
class MessageSnakFormatter implements SnakFormatter {
+
+ /**
+ * @var string[]
+ */
+ private static $snakTypeCssClasses = array(
+ 'somevalue' => 'wikibase-snakview-variation-somevaluesnak',
+ 'novalue' => 'wikibase-snakview-variation-novaluesnak',
+ );
/**
* @var string One of the SnakFormatter::FORMAT_... constants.
@@ -83,6 +93,15 @@
return $this->message->text();
} elseif ( strpos( $this->format, SnakFormatter::FORMAT_HTML )
=== 0 ) {
$html = $this->message->parse();
+
+ if ( array_key_exists( $this->snakType,
self::$snakTypeCssClasses ) ) {
+ $html = Html::rawElement(
+ 'span',
+ array( 'class' =>
self::$snakTypeCssClasses[$this->snakType] ),
+ $html
+ );
+ }
+
return $html;
}
diff --git a/lib/tests/phpunit/formatters/MessageSnakFormatterTest.php
b/lib/tests/phpunit/formatters/MessageSnakFormatterTest.php
index d13fe01..225ee0d 100644
--- a/lib/tests/phpunit/formatters/MessageSnakFormatterTest.php
+++ b/lib/tests/phpunit/formatters/MessageSnakFormatterTest.php
@@ -84,11 +84,11 @@
),
array(
new PropertySomeValueSnak( $id ),
- 'parse'
+ '<span
class="wikibase-snakview-variation-somevaluesnak">parse</span>'
),
array(
new PropertyNoValueSnak( $id ),
- 'parse'
+ '<span
class="wikibase-snakview-variation-novaluesnak">parse</span>'
),
);
}
--
To view, visit https://gerrit.wikimedia.org/r/195877
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I51618f059ed1529149de33ea482fa698212755b3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de>
Gerrit-Reviewer: Adrian Lang <adrian.he...@wikimedia.de>
Gerrit-Reviewer: Aude <aude.w...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
