jenkins-bot has submitted this change and it was merged.
Change subject: Don't log page-impression or widget-impression
......................................................................
Don't log page-impression or widget-impression
Bug: T94443
Change-Id: Iec33ff6919ca0cf9f704c5b217ffee2cb54fb67d
---
M resources/dialog/WikiGrokDialog.js
1 file changed, 4 insertions(+), 5 deletions(-)
Approvals:
Phuedx: Looks good to me, approved
jenkins-bot: Verified
diff --git a/resources/dialog/WikiGrokDialog.js
b/resources/dialog/WikiGrokDialog.js
index abd9a73..3273e4d 100644
--- a/resources/dialog/WikiGrokDialog.js
+++ b/resources/dialog/WikiGrokDialog.js
@@ -79,8 +79,6 @@
/** @inheritdoc */
initialize: function ( options ) {
- var self = this;
-
// Remove any disambiguation parentheticals from the
title.
options.name = options.title.replace( / \(.+\)$/, '' );
@@ -95,10 +93,11 @@
} );
Panel.prototype.initialize.apply( this, arguments );
- this.once( 'show', function () {
+ // Disable logging page-impression and
widget-impression for now
+ //this.once( 'show', function () {
//self.logPageImpression();
- self.initializeWidgetImpressionLogging();
- } );
+ //self.initializeWidgetImpressionLogging();
+ //} );
},
/**
--
To view, visit https://gerrit.wikimedia.org/r/200731
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iec33ff6919ca0cf9f704c5b217ffee2cb54fb67d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikiGrok
Gerrit-Branch: master
Gerrit-Owner: Bmansurov <bmansu...@wikimedia.org>
Gerrit-Reviewer: Phuedx <g...@samsmith.io>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
