Matthias Mullie has uploaded a new change for review. https://gerrit.wikimedia.org/r/200853
Change subject: Show revisions from deleted boards in DeletedContribtions instead of Contributions ...................................................................... Show revisions from deleted boards in DeletedContribtions instead of Contributions Change-Id: Ifee23aca889e53cc369e64a59614536d21a86667 --- M includes/Formatter/ContributionsQuery.php 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Flow refs/changes/53/200853/1 diff --git a/includes/Formatter/ContributionsQuery.php b/includes/Formatter/ContributionsQuery.php index efe5092..c73acc5 100644 --- a/includes/Formatter/ContributionsQuery.php +++ b/includes/Formatter/ContributionsQuery.php @@ -73,16 +73,16 @@ try { $result = $pager instanceof ContribsPager ? new ContributionsRow : new DeletedContributionsRow; $result = $this->buildResult( $revision, $pager->getIndexField(), $result ); + $deleted = $result->currentRevision->isDeleted() || $result->workflow->getOwnerTitle()->isDeleted(); - // @todo: below code should also check status of board: if that's been deleted, it's posts should also be considered deleted if ( $result instanceof ContributionsRow && - ( $result->currentRevision->isDeleted() || $result->currentRevision->isSuppressed() ) + ( $deleted || $result->currentRevision->isSuppressed() ) ) { // don't show deleted or suppressed entries in Special:Contributions continue; } - if ( $result instanceof DeletedContributionsRow && !$result->currentRevision->isDeleted() ) { + if ( $result instanceof DeletedContributionsRow && !$deleted ) { // only show deleted entries in Special:DeletedContributions continue; } -- To view, visit https://gerrit.wikimedia.org/r/200853 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ifee23aca889e53cc369e64a59614536d21a86667 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Flow Gerrit-Branch: master Gerrit-Owner: Matthias Mullie <mmul...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits