jenkins-bot has submitted this change and it was merged.
Change subject: Hygiene: Remove unused activateForm handler
......................................................................
Hygiene: Remove unused activateForm handler
Change-Id: Ifa77ec2b51b484af276239c621f3ca55d98d83ca
---
M modules/engine/components/board/base/flow-board-interactive-events.js
1 file changed, 0 insertions(+), 50 deletions(-)
Approvals:
Matthias Mullie: Looks good to me, approved
jenkins-bot: Verified
diff --git
a/modules/engine/components/board/base/flow-board-interactive-events.js
b/modules/engine/components/board/base/flow-board-interactive-events.js
index f06d05f..6e10caa 100644
--- a/modules/engine/components/board/base/flow-board-interactive-events.js
+++ b/modules/engine/components/board/base/flow-board-interactive-events.js
@@ -25,56 +25,6 @@
//
/**
- * The activateForm handler will expand, scroll to, and then focus onto
a form (target = field).
- * @param {Event} event
- * @returns {$.Promise}
- */
-
FlowBoardComponentInteractiveEventsMixin.UI.events.interactiveHandlers.activateForm
= function ( event ) {
- var $el, $form,
- href = $( this ).prop( 'href' ),
- hash = href.match( /#.+$/ ),
- $target = hash ? $( hash ) : false,
- flowBoard,
- $deferred = $.Deferred();
-
- // Can't find target.
- if ( !$target || !$target.length ) {
- return $deferred.reject().promise();
- }
-
- $el = $( hash[0] );
- $form = $el.closest( 'form' );
-
- // Can't find form to activate
- if ( !$el.length || !$form.length ) {
- return $deferred.reject().promise();
- }
-
- flowBoard = mw.flow.getPrototypeMethod( 'board',
'getInstanceByElement' )( $form );
-
- // Is this a hidden form or invisible field? Make it visible.
- flowBoard.emitWithReturn( 'showForm', $form );
-
- // Is this a form field? Scroll to the form instead of jumping.
- $form.conditionalScrollIntoView().queue( function ( next ) {
- var $el = $( hash[0] );
-
- // After scroll, focus onto the form field itself
- if ( $el.is( 'textarea, :text' ) ) {
- $el.focus();
- }
-
- // jQuery.dequeue
- next();
- });
-
- // OK, we're done here. Don't use the hard link.
- event.preventDefault();
-
- return $deferred.resolve().promise();
- };
-
- /**
* Toggles collapse state
*
* @param {Event} event
--
To view, visit https://gerrit.wikimedia.org/r/199282
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifa77ec2b51b484af276239c621f3ca55d98d83ca
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: EBernhardson <ebernhard...@wikimedia.org>
Gerrit-Reviewer: Matthias Mullie <mmul...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
