Yaron Koren has submitted this change and it was merged. Change subject: Changed SIO's parser functions to just call #subobject, when using SMWSQLStore3 ......................................................................
Changed SIO's parser functions to just call #subobject, when using SMWSQLStore3 Now that (a) #subobject allows for unnamed subobjects, and (b) SMWSQLStore3 is coming out, with its own DB schema, it made sense to turn #set_internal into an alias for #subobject. This is done by just having doSetInternal() call SMWSubobject::render(). Additionally, #set_internal_recurring_event actually just calls #subobject, in a similar fashion. Currently this is being done only when SMWSQLStore3 is used; but assuming this works out fine, there's no reason why it can't be done for SMWSQLStore2 as well, at least for SMW >= 1.8. Change-Id: I64c02cd8f15c929643860c7bcea227e5e0ffd241 --- M SemanticInternalObjects.php M SemanticInternalObjects_body.php 2 files changed, 96 insertions(+), 25 deletions(-) Approvals: Yaron Koren: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/34095 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I64c02cd8f15c929643860c7bcea227e5e0ffd241 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticInternalObjects Gerrit-Branch: master Gerrit-Owner: Yaron Koren <[email protected]> Gerrit-Reviewer: Yaron Koren <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
