Alexandros Kosiaris has uploaded a new change for review.
https://gerrit.wikimedia.org/r/201445
Change subject: base: is_virtual comparison fix
......................................................................
base: is_virtual comparison fix
facts are strings in puppet. Which means that direct boolean checks will
fail. Change the check in standard-packages to a string comparison
While at it convert the unless to an if since the new check is easier to
read in this form
Change-Id: I748236ca428dc6975991472fe0fc43aa446b1c3f
---
M modules/base/manifests/standard-packages.pp
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/operations/puppet
refs/changes/45/201445/1
diff --git a/modules/base/manifests/standard-packages.pp
b/modules/base/manifests/standard-packages.pp
index b10f605..5b943c1 100644
--- a/modules/base/manifests/standard-packages.pp
+++ b/modules/base/manifests/standard-packages.pp
@@ -53,7 +53,7 @@
}
# real-hardware specific
- unless $::is_virtual {
+ if $::is_virtual == 'false' {
package { 'mcelog': ensure => latest }
package { 'intel-microcode': ensure => latest }
}
--
To view, visit https://gerrit.wikimedia.org/r/201445
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I748236ca428dc6975991472fe0fc43aa446b1c3f
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Alexandros Kosiaris <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
