jenkins-bot has submitted this change and it was merged.
Change subject: Correctly position popups in RTL
......................................................................
Correctly position popups in RTL
CSS definitions should not be flipped when we calculate elements'
positions and offsets to position other elements inside them.
Bug: T94783
Change-Id: Iaf15561409b2b61bbf31fe79bf6e340d86f01cbb
---
M src/themes/mediawiki/widgets.less
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Catrope: Looks good to me, approved
jenkins-bot: Verified
diff --git a/src/themes/mediawiki/widgets.less
b/src/themes/mediawiki/widgets.less
index 659afbd..0400128 100644
--- a/src/themes/mediawiki/widgets.less
+++ b/src/themes/mediawiki/widgets.less
@@ -65,11 +65,13 @@
.theme-oo-ui-popupButtonWidget () {
&.oo-ui-buttonElement-frameless > .oo-ui-popupWidget {
// Compensate for icon being inset
+ /* @noflip */
left: 1em;
}
&.oo-ui-buttonElement-framed > .oo-ui-popupWidget {
// Compensate for icon being inset
+ /* @noflip */
left: 1.75em;
}
}
--
To view, visit https://gerrit.wikimedia.org/r/201606
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaf15561409b2b61bbf31fe79bf6e340d86f01cbb
Gerrit-PatchSet: 3
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Mooeypoo <[email protected]>
Gerrit-Reviewer: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: Catrope <[email protected]>
Gerrit-Reviewer: Mooeypoo <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
